Support Ethers 0.6.0+

[alisinabh]

Ethers 0.6.0 was released with several breaking changes that needs to be addressed in order for KMS signer to keep working with it. The changes that impacted KMS signer are related to the newly introduced transaction structs (e.g. Eip1559 and Legacy).

These changes are not backwards compatible as some requirements around transactions has changed. Older versions of Ethers can keep using version 0.0.3 of this library.

No further user action is required other than making sure their codebase is compatible with Ethers 0.6.0+.

I suggest at least a minor version bump.

[wchennc]

LGTM, although interesting to see from is removed from the transaction struct and now has to be passed in as a new param.

It looks like a major release to me since it's not backward compatible.

[alisinabh]

LGTM, although interesting to see from is removed from the transaction struct and now has to be passed in as a new param.

This is to reflect the actual transaction structure in EVM chains. The from address is a byproduct of signature and does not exist in an unsigned transaction payload. But this is taken care of in the new version of Ethers with the Transaction.Signed module.

It looks like a major release to me since it's not backward compatible.

One thing to note is that from user's perspective (public API) this change is transparent. As long as they conform to Ethers 0.6+ (which is enforced by this libraries mix.exs) they should be good to go. I'm personally okay with a minor or even a major release. Just not a patch one.

[wchennc]

LGTM, although interesting to see from is removed from the transaction struct and now has to be passed in as a new param.

This is to reflect the actual transaction structure in EVM chains. The from address is a byproduct of signature and does not exist in an unsigned transaction payload. But this is taken care of in the new version of Ethers with the Transaction.Signed module.

It looks like a major release to me since it's not backward compatible.

One thing to note is that from user's perspective (public API) this change is transparent. As long as they conform to Ethers 0.6+ (which is enforced by this libraries mix.exs) they should be good to go. I'm personally okay with a minor or even a major release. Just not a patch one.

👍 Minor sounds reasonable to me then.