Skip to content

feat: Refactor object spawn and unspawn logic #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MS-crew wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

feat: Refactor object spawn and unspawn logic #810

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 6 additions & 30 deletions EXILED/Exiled.API/Extensions/MirrorExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,16 +620,8 @@ public static void MoveNetworkIdentityObject(this NetworkIdentity identity, Vect
return;

identity.gameObject.transform.position = pos;
ObjectDestroyMessage objectDestroyMessage = new()
{
netId = identity.netId,
};

foreach (Player ply in Player.List)
{
ply.Connection.Send(objectDestroyMessage, 0);
SendSpawnMessageMethodInfo?.Invoke(null, new object[] { identity, ply.Connection });
}
NetworkServer.UnSpawn(identity.gameObject);
NetworkServer.Spawn(identity.gameObject);
}

/// <summary>
Expand All @@ -643,16 +635,8 @@ public static void ScaleNetworkIdentityObject(this NetworkIdentity identity, Vec
return;

identity.gameObject.transform.localScale = scale;
ObjectDestroyMessage objectDestroyMessage = new()
{
netId = identity.netId,
};

foreach (Player ply in Player.List)
{
ply.Connection.Send(objectDestroyMessage, 0);
SendSpawnMessageMethodInfo?.Invoke(null, new object[] { identity, ply.Connection });
}
NetworkServer.UnSpawn(identity.gameObject);
NetworkServer.Spawn(identity.gameObject);
}

/// <summary>
Expand Down Expand Up @@ -788,16 +772,8 @@ public static void EditNetworkObject(NetworkIdentity identity, Action<NetworkIde
{
customAction.Invoke(identity);

ObjectDestroyMessage objectDestroyMessage = new()
{
netId = identity.netId,
};

foreach (Player player in Player.List)
{
player.Connection.Send(objectDestroyMessage, 0);
SendSpawnMessageMethodInfo.Invoke(null, new object[] { identity, player.Connection });
}
NetworkServer.UnSpawn(identity.gameObject);
NetworkServer.Spawn(identity.gameObject);
}

// Get components index in identity.(private)
Expand Down
Loading