Fix historical SQL timestamp conversion - #6
Open
Evolvion wants to merge 1 commit into
Open
Conversation
Preserve pre-1900 timestamp calendar fields as UTC to prevent valid year-0001 values from becoming XML-invalid year zero. Apply the same field-based policy to writes and filter parameters while retaining existing conversion for newer timestamps. Document the deliberate historical-timezone limitation and add regression coverage for UTC and Europe/Bratislava, boundary dates, XML validity, round-trips, and filter binding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Valid timestamps such as
0001-01-01could be converted to year zero through legacy Java calendar handling, then rejected by midPoint's XML date parser.Fix and rationale
9999, is left unchanged. Date-only and timezone-aware mappings are also unchanged.Testing
mvn -o -B test.