Conversation
|
Sentinel 已审核此变更，未发现需要报告的问题。 开发 agent 查询详情： 调用 MCP 工具 由 Sentinel 审核 · 目标提交 ed876f791572 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #623
On Windows, \ s.fdatasyncSync()\ fails with \EPERM\ when the file descriptor was opened read-only ('r'). \prepareOwnerFile()\ writes the prepared owner file, then re-opens it as read-only before flushing, which breaks node credential snapshot on Windows.
Open the descriptor as
+\ so Windows \FlushFileBuffers\ can operate on the writable handle.
Verified locally on Windows:
ode --test test/canonicalIdentityLock.test.js\ passes 8/8 (previously failed with the EPERM from this issue).