feat: add envInt override for TARGETBYTES, ACTIVEWINDOWMS, PERFILE/SESSION_BYTES + validate-suite quick mode#533
Conversation
…E/SESSION_BYTES - src/config.js: 4 hardcoded values now accept env variable overrides via EVOLVER_TARGET_BYTES, EVOLVER_ACTIVE_WINDOW_MS, EVOLVER_PER_FILE_BYTES, EVOLVER_PER_SESSION_BYTES - scripts/validate-suite.js: default runs a quick curated subset (~15 test files / 277 assertions / ~7s) instead of all 97 tests. Pass --full to run the full test suite. This prevents ETIMEDOUT in evolution validation steps and makes session ingest volume configurable at deploy time. Ref: community issue EvoMap#514 (validate-suite timeout)
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fe40fa8. Configure here.
| // Flags: --full runs all test files (default is a curated quick subset). | ||
| const nonFlagArgs = process.argv.slice(2).filter(a => !a.startsWith('--')); | ||
| const useQuickSubset = !process.argv.includes('--full'); | ||
| const pattern = useQuickSubset ? null : (nonFlagArgs[0] || 'test/*.test.js'); |
There was a problem hiding this comment.
Explicit test pattern argument silently ignored without --full
Medium Severity
When a user passes an explicit test file (e.g., node scripts/validate-suite.js test/myTest.test.js), useQuickSubset is still true because it only checks for the absence of --full. This causes pattern to be null, silently ignoring the user's explicit argument and running the quick subset instead. The comment on line 6 and the PR description both state that passing an explicit pattern should bypass quick mode, but the condition doesn't account for nonFlagArgs.length > 0.
Reviewed by Cursor Bugbot for commit fe40fa8. Configure here.
1 participant
…E/SESSION_BYTES
This prevents ETIMEDOUT in evolution validation steps and makes session ingest volume configurable at deploy time.
Ref: community issue #514 (validate-suite timeout)
Summary
Short 1-2 sentence summary of the change.
What changed
How to test
Risk
Low / Medium / High -- note if it touches infra or public API.
Related
Closes #NN
Note
Medium Risk
Medium risk because it changes default test coverage for
scripts/validate-suite.jsand introduces new environment-driven runtime tuning that could alter behavior if misconfigured.Overview
Config: Replaces four previously hardcoded limits with environment-overridable settings (
EVOLVER_ACTIVE_WINDOW_MS,EVOLVER_TARGET_BYTES,EVOLVER_PER_FILE_BYTES,EVOLVER_PER_SESSION_BYTES).Tooling: Updates
scripts/validate-suite.jsto default to a curated “quick” test subset (excluding known slow/external-dependent tests), adds--fullto run the entire suite or accept an explicit pattern, and increases the test runner timeout from 3 to 10 minutes.Reviewed by Cursor Bugbot for commit fe40fa8. Bugbot is set up for automated code reviews on this repo. Configure here.