Prove the step did not wait by what it carries, not by a stopwatch - #22
Merged
Merged
Conversation
The slow-prime test asserted the step returned within 120ms against a server that answers in 150ms -- a 30ms margin on shared CI. It went red on main right after #21 and passed on a rerun, which is the definition of a test that reports the runner's load rather than the code. The assertion below it already proves the thing: a step that waited for the slow search would come back carrying its strategy, so an empty `primed` is the evidence. Raising the wait budget until the step really does wait still fails the test with the stopwatch gone. #21 made the suite heavier -- evolver-core is imported for the root-event write -- so a margin that was always thin was going to keep flaking. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes a wall-clock assertion from the slow-prime test.
Why
The stub server answers in 150ms, so this is a 30ms margin on shared CI. It went red on
mainimmediately after #21 and passed on a rerun — a test reporting the runner's load rather than the code.#21made the suite heavier (evolver-core is imported for the root-event write), so a margin that was always thin was going to keep flaking.Nothing is lost
The next line already proves it:
A step that waited would return the strategy inline. Verified by sabotage: raising
assetPrimeWaitMsfrom 20 to 5000 — so the step genuinely does wait — still fails the test with the stopwatch gone.Test count unchanged at 91.
🤖 Generated with Claude Code