Skip to content

fix: keep native evidence complete after a failed claim release - #79

Open
imxyanua wants to merge 1 commit into
EvoMap:mainfrom
imxyanua:codex/complete-native-evidence
Open

imxyanua wants to merge 1 commit into
EvoMap:mainfrom
imxyanua:codex/complete-native-evidence

Conversation

@imxyanua

Copy link
Copy Markdown
Contributor

Summary

A temporary evidence read failure followed by a failed claim release can leave a fresh .taking file behind. An immediate native retry previously omitted that claim and could finish the turn with empty evidence.

Require complete notes and baseline takes. A native retry waits for every earlier claim and surfaces claim access errors. Generic report and retention queues retain their concurrent append behavior.

Evidence

  • The regression reproduced a successful empty retry after read and release metadata errors on c3d78ac.
  • With the fix, retry reports ELOCKED and keeps the turn open until its evidence can be recovered, then produces one report and candidate.
  • Tests also preserve generic concurrent takes and verify that an epoch change while reading notes queues no old report.
  • Lifecycle, file-store, lock and architecture tests passed 119/119 on Windows Node 22.23.4 and 26.13.0.

Merge Danger

Two-way. Scope is evidence completeness during native retry. Continuing access failures leave the turn waiting for the claim to be released or expire.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T03:38:56.671346Z 362b251 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@evomap-aiqa-bot

evomap-aiqa-bot Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Sentinel 已审核此变更,并发现 1 个已核验问题。

无法定位到 diff 的已核验问题

claim 重命名成功但更新时间失败时遗留未跟踪占用

🟠 严重程度:中(P2)
claimed() 先将源文件重命名为随机 .taking 文件,再调用 utimesSync。如果重命名成功但 utimesSync 因 EACCES、EPERM 或瞬时文件系统错误失败,函数直接抛错;该 claim 尚未加入 claims,外层 release()...(truncated)

Finding:finding_1f52c6b8e11c0223be242dc6 · 文件:lib/runtime/store/file-lock.js · 详情:/api/v1/aiqa/findings/finding_1f52c6b8e11c0223be242dc6

当前为 advisory 仓库:这些 item 会逐条保留,但不阻塞合并。

开发 agent 查询详情: 调用 MCP 工具 sentinel_pr_review_context,传入 owner_repo="evomap/evolver-agent-plugin"、pr_number=79、head_sha="362b2517c28750465926bb3ed136e77cf5881a4d",并按条目追加 finding_id 或 finding_key。

由 Sentinel 审核 · 目标提交 362b2517c287

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant