feature-video: remove hardcoded R2 URL and require public URL verification#197
Merged
kieranklaassen merged 1 commit intoEveryInc:mainfrom Feb 19, 2026
Conversation
Collaborator
|
TY |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
feature-videocommand hardcodes a specific R2 public domain (pub-404...r2.dev) and assumes it works for all users.In practice, users can upload successfully with
rclonebut still get broken demo links in PRs due to:What this changes
PUBLIC_BASE_URLvariable.VIDEO_URLandPREVIEW_URLcurl -Iboth URLs200for both before updating the PR body.<your-public-r2-domain>placeholder.Why this is objective and low-risk
Validation