Introduce AreasRecycleBin instead of deleting unloaded AreaStats#1003
Open
Wartori54 wants to merge 2 commits intoEverestAPI:devfrom
Open
Introduce AreasRecycleBin instead of deleting unloaded AreaStats#1003Wartori54 wants to merge 2 commits intoEverestAPI:devfrom
Wartori54 wants to merge 2 commits intoEverestAPI:devfrom
Conversation
DashingCat
approved these changes
Oct 6, 2025
Contributor
DashingCat
left a comment
There was a problem hiding this comment.
I was able to reproduce the linked issue (#989) and in my testing this PR fixes the issue.
I would maybe add a few things to make the code a bit clearer :
- some logging when adding an area to
areasBin; - some kind of constants for
int.MaxValueandint.MaxValue - 1, maybe likemissingAreaIDandsubAreaID; - a comment explaining how an area can end up in the
areasBin.
Member
Author
|
@DashingCat thank you for your review, I have applied the feedback from your comment in the latest commit. I have also added xmldocs and logging for the very similar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #989. Introduces a new field in
LevelSetStatswhich stores theAreaStatsthat have no matching loadedAreaData. This makes it so the extraAreaStatsare not deleted but instead moved elsewhere, then each time save data is loaded thoseAreaStatsare taken into account again and potentially moved back to the mainAreas list.Since this PR touches
SaveDatacode, I'd appreciate if it could get three approvals instead before merging.