Add "/setmaxplayers" command. - #6620
Open
Mickey42302 wants to merge 4 commits into
Open
Mickey42302 wants to merge 4 commits into
Mickey42302 wants to merge 4 commits into
Conversation
Added descriptions and usage instructions for setmaxplayers command.
GiansCode
added a commit
to GiansCode/Essentials
that referenced
this pull request
Sep 25, 2026
Member
|
I think this PR is cool, but before considering it for merging I recommend looking at what other existing commands already do in terms of number handling and implementing translatable text, since right now what you have is hard coded. I'm also not sure what your tab complete options are trying to achieve here but realistically you probably don't need any tab complete at all on this command, the user will enter any number and get an error message if it's not a number. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to suggest adding a "/setmaxplayers" command. This command allows a person with operator privileges to change the player limit without needing to restart the server.