perf: reduce command map iteration and avoid redundant cache puts#6526
Open
1wairesd wants to merge 7 commits intoEssentialsX:2.xfrom
Open
perf: reduce command map iteration and avoid redundant cache puts#65261wairesd wants to merge 7 commits intoEssentialsX:2.xfrom
1wairesd wants to merge 7 commits intoEssentialsX:2.xfrom
Conversation
- AlternativeCommandsHandler: add addPlugins() for bulk registration in a single pass over known commands (O(plugins*commands) -> O(commands)); extract registerPluginCommands() shared by both addPlugin/addPlugins - Settings.reloadConfig: use addPlugins() instead of per-plugin loop - ModernUserMap.getUser(Player): skip loadUncachedUser/put when player is already cached with the same Player instance
Member
|
Please fill out the PR template as requested when you opened the PR :) You can find the appropriate templates here. Since this is an optimisation, it would also be good if you could provide startup timings showing the real-world improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a single pass over known commands (O(plugins*commands) -> O(commands));
extract registerPluginCommands() shared by both addPlugin/addPlugins
is already cached with the same Player instance