-
Notifications
You must be signed in to change notification settings - Fork 13
New Add Building Scene Layer sample #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v.next
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file shouldn't have snuck in here
| 2. Create an `ArcGISTiledElevationSource` object and add it to the local scene's base surface. | ||
| 3. Create a `BuildingSceneLayer` and add it to the local scene's operational layers. | ||
| 4. Create a `ArcGISLocalSceneView` object to display the scene. | ||
| 5. Set the local scene to the `ArcGISLocalSceneView`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Steps 4 & 5 are a little weird -- the scene isn't added to the ArcGISLocalSceneView, it's added to the ArcGISLocalSceneViewController. I'm not sure if that's a little too nuanced to worry about, though.
FilterBuildingSceneLayer just has a single step to cover both:
2. Create a LocalSceneView and add the scene.|
|
||
| late final BuildingSublayer _overviewSublayer; | ||
| late final BuildingSublayer _fullModelSublayer; | ||
| var _showFullModel = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these three should have comments
| Column( | ||
| children: [ | ||
| Expanded( | ||
| // Add a map view to the widget tree and set a controller. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a map view
| Row( | ||
| mainAxisAlignment: MainAxisAlignment.spaceEvenly, | ||
| children: [ | ||
| // A button to perform a task. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update comment
| // Add the BuildingSceneLayer to the Scene. | ||
| scene.operationalLayers.add(buildingSceneLayer); | ||
|
|
||
| // Extract the overview and full model sublayers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
period
| setState(() => _ready = true); | ||
| } | ||
|
|
||
| Future<ArcGISScene> _initializeScene() async { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no awaiting going on, so this can be
ArcGISScene _initializeScene() {| return scene; | ||
| } | ||
|
|
||
| Future<void> toggleModelView() async { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
likewise
void toggleModelView() {
Implementation of the "Add Building Scene Layer" sample illustrating how to add a
BuildingSceneLayerto anArcGISLocalSceneView.