Skip to content

Conversation

@kmueller-gis
Copy link
Collaborator

Implementation of the "Add Building Scene Layer" sample illustrating how to add a BuildingSceneLayer to an ArcGISLocalSceneView.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file shouldn't have snuck in here

@PaulAllanSturm PaulAllanSturm self-requested a review December 9, 2025 22:27
2. Create an `ArcGISTiledElevationSource` object and add it to the local scene's base surface.
3. Create a `BuildingSceneLayer` and add it to the local scene's operational layers.
4. Create a `ArcGISLocalSceneView` object to display the scene.
5. Set the local scene to the `ArcGISLocalSceneView`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Steps 4 & 5 are a little weird -- the scene isn't added to the ArcGISLocalSceneView, it's added to the ArcGISLocalSceneViewController. I'm not sure if that's a little too nuanced to worry about, though.

FilterBuildingSceneLayer just has a single step to cover both:

2. Create a LocalSceneView and add the scene.


late final BuildingSublayer _overviewSublayer;
late final BuildingSublayer _fullModelSublayer;
var _showFullModel = false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these three should have comments

Column(
children: [
Expanded(
// Add a map view to the widget tree and set a controller.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a map view

Row(
mainAxisAlignment: MainAxisAlignment.spaceEvenly,
children: [
// A button to perform a task.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update comment

// Add the BuildingSceneLayer to the Scene.
scene.operationalLayers.add(buildingSceneLayer);

// Extract the overview and full model sublayers
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

period

setState(() => _ready = true);
}

Future<ArcGISScene> _initializeScene() async {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no awaiting going on, so this can be

ArcGISScene _initializeScene() {

return scene;
}

Future<void> toggleModelView() async {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likewise

void toggleModelView() {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants