Remove python toolchain#252
Open
furtib wants to merge 1 commit into
Open
Conversation
furtib
added
enhancement
furtib
removed
non-functional change ☮️
Szelethus
reviewed
Jul 1, 2026
|
|
||
| # Tool filter compile_commands.json file | ||
| # In bazel 6 we use our own python toolchain, | ||
| # In bazel 6 we use the built in python toolchain, |
Contributor
There was a problem hiding this comment.
We no longer use bazel 6, this is worth updating.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
The situation around the Python toolchain is very complicated.
We use a self-created Python toolchain as well as the official rules_python toolchain.
We do not use either toolchain at all, so to keep it simple (KISS), let's remove them completely.
If we really do need it (e.g., to obtain packages through pip with rules_python), we should add it back in the PR where it becomes necessary.
What:
Removed every Python toolchain from the project.
Addresses:
Fixes: #251