Repository navigation
Match the scan transcript to the format strings that print it - #9
Open
kridaydave wants to merge 1 commit into
Open
kridaydave wants to merge 1 commit into
kridaydave wants to merge 1 commit into
Conversation
The runtimes and containers lines in the README transcript were indented
four spaces and padded to 20 columns from position four, which is what a
hand-aligned table looks like. The code prints
" {:<20} {} (pinned)" at cli.rs:609 and " {:<20} {} -> {}" at
cli.rs:620, which is two spaces of indent and the pad starting at
position two.
Reproduced both format strings and compared them to the README byte for
byte. All three lines now match exactly, including the arrow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
scantranscript in the README is not what the tool prints. The runtime and container rows are indented four spaces with the column padding starting at position four, which is how a hand-aligned table looks. The code prints two spaces of indent with the pad starting at position two.Evidence
The code prints:
src/cli.rs:609—println!(" {:<20} {} (pinned)", r.name, r.version);src/cli.rs:620—println!(" {:<20} {} → {}", c.name, c.image, c.version);Rendered,
nodeproduces 38 characters beginningnode 20.5.0 (pinned). The README line 29 was 41 characters beginningnode 20.5.0 (pinned).I reproduced both format strings and compared them to the README byte for byte. Line 29 and line 30 were each 41 characters against a real 38, and line 33 was 46 against a real 38. The
→arrow was already correct, and the 41-character divider matched all sixteen insrc/cli.rs, so only the three rows drifted.Change
Three lines, indent and padding corrected. All three now match the format strings exactly. The
mounttranscript below them is untouched and was already correct.Not shipped
action.yml:36-39declares aregistry-pathinput.scripts/run.sh:11assigns it toREGISTRY_PATHand never reads it again. Deleting an input from a published GitHub Action changes its public interface, so it needs the owner's call rather than a drive-by.README.md:135cites corpus counts ("23 bottlenecks, 21 sources") from a different repo, so this repo cannot verify them.