Repository navigation
Delete the two unused locals in the composite action script - #11
Open
kridaydave wants to merge 1 commit into
Open
kridaydave wants to merge 1 commit into
kridaydave wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete the two locals in the composite action script that nothing reads.
escape_wf_colonis defined at scripts/run.sh:41 and never called. Its onlyreference anywhere in the tree is its own definition.
REGISTRY_PATHisassigned at scripts/run.sh:11 from the
registry-pathaction input and neverread, so the input the action advertises has never reached any behavior.
escape_wfstays. It has four live callers.Neither removal touches a code path, so drift and verify behavior are
unchanged. Verified by running the action's own remote-baseline path against a
stubbed registry with a fake curl on PATH and comparing the Authorization
header byte for byte before and after; the header is identical.
Not shipped: the
registry-pathaction input itself is left in place.Removing a documented input is an API change, which is the owner's call.