Dev local #1
Merged
Dev local #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was an automatic fix by copilot, but has been manually reviewed by: Argo Nickerson
- Fixed test_detect_system_locale failing on macOS-latest Python 3.11 - Replaced @patch.dict decorator with explicit environment variable management - Ensured LC_ALL/LC_MESSAGES don't interfere with LANG test variable - Added proper environment cleanup and restoration in test - Removed unused unittest.mock.patch import - Fixed code formatting and linting issues The test was failing because macOS CI sets LC_ALL/LC_MESSAGES which take precedence over LANG in locale detection. Now explicitly clears all locale env vars before setting test LANG value. Resolves: GitHub Actions macOS test failure All 24 tests now pass with
Member
Author
|
Reference for reviewer: Most issues encountered so far have been the result of a faulty workflow run, so many changes to .github/workflows/ci.yml have been proposed to fix bad versioning, imports, etc |
Import sys and use assertions to ensure that only windows can run the windows functions, and mac can only run mac, etc
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces the complete implementation of pyLocalEngine, a Python localization framework following the LocalEngine specification. The PR adds a comprehensive localization system with automatic locale detection, dynamic locale switching, and support for multiple file formats (JSON, XML, YAML).
- Complete LocalEngine implementation with core components (engine, file manager, locale detector, exceptions)
- Comprehensive test suite with 24 tests covering all functionality
- Documentation, examples, migration tools, and CI/CD pipeline setup
Reviewed Changes
Copilot reviewed 32 out of 33 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| localengine/ | Core implementation package with engine, file manager, locale detector, and exception handling |
| tests/ | Complete test suite with isolated test environments and comprehensive coverage |
| examples/ | Demonstration scripts showing basic usage, advanced features, remote loading, and benchmarking |
| tools/migrate.py | Migration utility supporting i18next, gettext, Django, and React Intl formats |
| locales/ | Example locale files in JSON, XML, and YAML formats for multiple languages |
| setup.py, pyproject.toml | Package configuration with proper dependencies and metadata |
| ci-test.sh | Local CI/CD test script emulating GitHub Actions workflow |
| .github/workflows/ | CI/CD pipeline with multi-platform testing and PyPI publishing |
| Makefile | Development workflow automation with common tasks |
| README.md, USER.md, DOCS.md | Comprehensive documentation covering usage, API reference, and architecture |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.