fix(agent-providers): stabilize Copilot and Pi SDK runs#1493
Merged
Conversation
Entire-Checkpoint: db325365b92c
Deploying agentv with
|
| Latest commit: |
392ea7a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d6a147f8.agentv.pages.dev |
| Branch Preview URL: | https://fix-copilot-sdk-epipe.agentv.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RuntimeConnection.forTcp()for AgentV-owned Copilot SDK runtimes, falling back to stdio only for older SDKsdocs/learnings/best-practices/Why
@github/copilot-sdk@1.0.3stdio transport can rethrow a child stdinEPIPEafter the assistant turn completes, matching upstreamgithub/copilot-sdk#1427. AgentV should avoid that via the SDK-supported TCP transport rather than adding a process-wide exception handler or reaching into private SDK lifecycle fields.For PI, the current
@earendil-works/pi-coding-agent@0.79.10SDK expects built-in tool selection as names likeread,bash,edit, andwrite. AgentV was constructing a tool object allowlist from exports that are not present in the current SDK.Validation
bun test packages/core/test/evaluation/providers/copilot-sdk.test.tsbun test packages/core/test/evaluation/providers/pi-coding-agent.test.tsbun --filter @agentv/core build && bun --filter agentv buildgit diff --checkexamples/features/basic/evals/dataset.eval.yaml --test-id shorthand-string-example --target agentv-pi-sdk-openai: 100% PASS, provider time 6.273sexamples/features/basic/evals/dataset.eval.yaml --test-id shorthand-string-example --target agentv-copilot-sdk-openai: 100% PASS, provider time 18.546sVersion checks
@github/copilot-sdk: local1.0.3, npm latest1.0.3@github/copilot: local SDK dependency1.0.64-1; npm latest tag is1.0.63, prerelease is1.0.64-3@earendil-works/pi-coding-agent: managed local0.79.10, npm latest0.79.10@earendil-works/pi-ai: nested PI dependency0.79.10, npm latest0.79.10Notes
The heavier Next eval smoke was intentionally replaced with the short
examples/features/basicprovider smoke after confirming it was a better fit for validating provider wiring quickly.