Repository navigation
Record stored addresses in the manifest and refuse subfolder sites - #151
Merged
Merged
Conversation
manifest.txt now records the home and siteurl options as home_url and site_url, as EngineScript's own exports do, instead of home_url() and site_url(), which follow the admin page's scheme and plugin filters. The warning about missing WP_HOME and WP_SITEURL is removed, since the importer reads the address from the manifest. A site whose Site Address or WordPress Address has a path (/blog, or WordPress in its own /wp folder) is no longer exported: EngineScript only hosts sites at the root of their domain. The exporter page shows an error in place of the form, and an export request is refused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
documentation
Contributor
|
Thanks for contributing to EngineScript Site Exporter! Before we review:
Security Reminder
We'll review your PR soon. |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 9 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Plugin Check 2.2 refuses "Tested up to" in the plugin header. The WordPress version check script now tracks readme.txt only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin side of EngineScript's scripts audit (EngineScript/EngineScript#302, merged).
manifest.txtrecords thehomeandsiteurloptions (WP_HOMEandWP_SITEURLwhenwp-config.phpdefines them) ashome_urlandsite_url, as EngineScript's own exports do.home_url()andsite_url()took the scheme of the admin page and passed through plugin filters. EngineScript's importer reads the site address and table prefix from these lines.WP_HOMEnorWP_SITEURLis defined; the importer reads the address from the manifest./blog, WordPress in/wp) is not exported. EngineScript only hosts sites at the root of their domain, so the page shows an error with both addresses, and an export request gets the same error.Testing
composer check-allpasses (230 tests, including the newManifestTestandSiteLayoutTestcases).includes/export.php..pottemplate is regenerated and valid.🤖 Generated with Claude Code