Repository navigation
Emotiv ERP Setup - #251
Merged
Merged
Emotiv ERP Setup#251
Conversation
hoangphamemotiv
requested review from
thamha-emotiv
and
a balanced review from Copilot
November 13, 2026 09:32
thamha-emotiv
approved these changes
Nov 13, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The guide still needs to clarify that interval recording must wait for endpoint-update acknowledgments and distinguish counter sampling and platform-dependent resolution from actual stimulus-onset accuracy.
2 open issues
What changed in this PR
This PR adds ERP experiment setup guidance for the Python marker example and switches clock synchronization and marker timestamp generation to time.perf_counter().
Changes:
- Documents headset setup, clock synchronization, marker workflows, and record export.
- Uses the performance counter consistently for synchronization requests and marker timestamps.
| File | Description |
|---|---|
python/marker.py |
Uses time.perf_counter() to calculate marker timestamps. |
python/Emotiv_ERP_Setup.md |
Adds hardware setup and software workflow guidance for ERP experiments. |
python/cortex.py |
Uses time.perf_counter() in headset clock synchronization requests. |
Review effort: Balanced
| - **Step 4b:** When the event ends, call `update_marker(marker_id, end_time)` to set the end of the interval, converting the instance marker into an interval marker. | ||
|
|
||
| ### Step 5: Stop Record and Wait for Post-Processing (Warning Code 30) | ||
| Once all markers have been injected, the application calls `self.stop_record()`. |
|
|
||
| | Component | Unit | Description | | ||
| | :--- | :---: | :--- | | ||
| | `time.perf_counter()` | Seconds (`float`) | High-resolution monotonic performance counter captured at the exact moment the event occurs (uses `QueryPerformanceCounter` on Windows with `100 ns` resolution, avoiding the `15.625 ms` tick quantization of `GetTickCount64`). | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.