Repository navigation
Support custom simple CASE equality with ordered literal matching - #169
Merged
osipovartem merged 4 commits intoOct 27, 2026
Merged
Conversation
osipovartem
merged commit Oct 27, 2026
d749807
into
df55-physical-udf-instance
10 of 19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CASE, so an engine can use its predicate semantics without changing the default DataFusion path.Why
Snowflake VARIANT predicate equality between exact NUMBER and FLOAT is not transitive at precision boundaries. Replacing a simple
CASEbase with a hash/set key changes its answer. The hook keeps this behavior local to the engine that needs it; ordinary DataFusion CASE queries remain on their existing path.Validation
cargo +1.95.0 check -p datafusion-physical-exprandcargo +1.95.0 fmt --all -- --checkpassed locally.The consuming Rustice PR pins this fork commit and documents the focused Snowflake evidence. The full live corpus was not rerun for this change.