Skip to content

Route IS DISTINCT FROM through binary expression planners - #168

Merged
osipovartem merged 1 commit into
df55-physical-udf-instancefrom
variant-nullsafe-expr-planner
Oct 27, 2026
Merged

osipovartem merged 1 commit into
df55-physical-udf-instancefrom
variant-nullsafe-expr-planner

Conversation

@osipovartem

Copy link
Copy Markdown
Collaborator

Summary

  • Route IS DISTINCT FROM and IS NOT DISTINCT FROM through the existing null-safe (<=>) binary expression planner hook.
  • Preserve the original logical operators when planners leave operands unchanged; invert a fully planned null-safe expression for IS DISTINCT FROM.
  • Cover unchanged behavior, rewritten operands, and fully planned expressions.

Verification

  • cargo +1.95.0 test -p datafusion-sql --test sql_integration --offline: 656 passed.
  • cargo +1.95.0 clippy -p datafusion-sql --tests --offline -- -D warnings -A clippy::nonminimal_bool: passed; waiver is for pre-existing warnings in datafusion-expr.
  • Independent read-only review: approved with no blocking findings.

@github-actions github-actions Bot added the sql label Oct 27, 2026
@osipovartem
osipovartem merged commit a1eeb8f into df55-physical-udf-instance Oct 27, 2026
31 of 37 checks passed
@osipovartem
osipovartem deleted the variant-nullsafe-expr-planner branch October 27, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant