Repository navigation
Drain Parquet writer tasks before returning failures - #167
Merged
osipovartem merged 2 commits intoOct 26, 2026
Merged
Conversation
osipovartem
marked this pull request as ready for review
October 26, 2026 22:07
osipovartem
merged commit Oct 26, 2026
49e3f54
into
df55-physical-udf-instance
18 of 20 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
cargo +1.97.0 test -p datafusion-datasource-parquet --lib writer_error_waits_for_other_writers_to_stop: 1 passed locally after the Clippy fix.-D warnings), Rust 1.94cargo check -p datafusion(MSRV),cargo +1.97.0 fmt --all -- --check, andgit diff --checkpassed locally.7955d2650passed the 541-file, 4195-case strict SQLLogicTest corpus. The final11874e4bacommit only collapses two behavior-equivalent conditions for Clippy; Rustice now pins that final SHA.Performance and dependency
7955d2650with base6770c7c34using the same release-mode DataFusion harness; final11874e4baonly changes behavior-equivalent let-chain syntax: 1,048,576 rows, one or 32 local Parquet files, five warmups and 20 samples per run, 15 alternating A/B pairs. Median paired change was +1.08% for one file (about 0.25 ms) and +1.58% for 32 files (about 1.6 ms). The shorter 131,072-row run was noisier (+4.32% and +0.1% over 20 pairs); the patched single-file run was faster in 9/20 pairs.CI notes