Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the spaces feature by allowing fine-grained control over feature visibility within individual spaces. The changes enable space administrators to hide disabled features from the front page counters and optionally hide the spaces index from the navigation dropdown while keeping it accessible via the footer.
Changes:
- Added 'spaces' to the list of features that can be disabled per-space
- Updated counter display logic to respect space-specific feature flags
- Added a "Browse Spaces" link to the footer for global spaces access
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| app/models/space.rb | Added 'spaces' to FEATURES constant to enable per-space control |
| app/views/static/home/_counters.html.erb | Changed feature filtering to use feature_enabled? helper, respecting both global and space-specific flags |
| app/views/layouts/_footer.html.erb | Added "Browse Spaces" link to footer with global feature flag check |
| config/locales/en.yml | Added browse_spaces translation key for the footer link |
| test/controllers/static_controller_test.rb | Added tests for disabled feature counter hiding and spaces index visibility behavior |
| test/controllers/spaces_controller_test.rb | Updated test count to reflect addition of 'spaces' to available features |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Motivation and context
Hiding empty/irrelevant content.
Checklist
to license it to the TeSS codebase under the
BSD license.