Skip to content

pyln-proto: update coincurve to commit 7829b29c08ebb1cc80386a1cdaf8c2243c4ef5c5#9288

Merged
madelinevibes merged 1 commit into
ElementsProject:masterfrom
daywalker90:coincurve-master
Jul 9, 2026
Merged

pyln-proto: update coincurve to commit 7829b29c08ebb1cc80386a1cdaf8c2243c4ef5c5#9288
madelinevibes merged 1 commit into
ElementsProject:masterfrom
daywalker90:coincurve-master

Conversation

@daywalker90

@daywalker90 daywalker90 commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator
 DEBUG: DEBUG ERROR: Use build.verbose instead of cmake.verbose for scikit-build-core >= 0.10
 DEBUG:   × Failed to build `coincurve==20.0.0`
 DEBUG:   ├─▶ The build backend returned an error
 DEBUG:   ╰─▶ Call to `hatchling.build.build_wheel` failed (exit status: 7)
 DEBUG:
 DEBUG:       [stderr]
 DEBUG:       ERROR: Use build.verbose instead of cmake.verbose for scikit-build-core
 DEBUG:       >= 0.10
 DEBUG:
 DEBUG:
 DEBUG: hint: `coincurve` (v20.0.0) was included because `testpluguv` (v0.1.0) depends on `pyln-client` (v26.6.2) which depends on `pyln-proto` (v26.6.2) which depends on `coincurve`

This error is caused because coincurve v20 depending on scikit-build-core>=0.9.0 and they did a new release where using cmake.verbose is no longer a warning but an error. coincurve v21 is using the correct build.verbose but it is not working with python 3.14. So we update coincurve to current master, which fixes all of this.

Changelog-None

Important

26.09 FREEZE August 5th: Non-bugfix PRs not ready by this date will wait for 26.12.

RC1 is scheduled on August 17th

The final release is scheduled for September 7th.

Checklist

Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:

  • The changelog has been updated in the relevant commit(s) according to the guidelines.
  • Tests have been added or modified to reflect the changes.
  • Documentation has been reviewed and updated as needed.
  • Related issues have been listed and linked, including any that this PR closes.
  • Important All PRs must consider how to reverse any persistent changes for tools/lightning-downgrade

@daywalker90 daywalker90 closed this Jul 7, 2026
@daywalker90 daywalker90 reopened this Jul 8, 2026
@daywalker90 daywalker90 linked an issue Jul 8, 2026 that may be closed by this pull request
@daywalker90 daywalker90 added the Status::Ready for Review The work has been completed and is now awaiting evaluation or approval. label Jul 8, 2026
@madelinevibes madelinevibes self-requested a review July 9, 2026 01:05
@madelinevibes madelinevibes added this to the v26.09 milestone Jul 9, 2026

@madelinevibes madelinevibes left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack 6d3375a

…243c4ef5c5

```
 DEBUG: DEBUG ERROR: Use build.verbose instead of cmake.verbose for scikit-build-core >= 0.10
 DEBUG:   × Failed to build `coincurve==20.0.0`
 DEBUG:   ├─▶ The build backend returned an error
 DEBUG:   ╰─▶ Call to `hatchling.build.build_wheel` failed (exit status: 7)
 DEBUG:
 DEBUG:       [stderr]
 DEBUG:       ERROR: Use build.verbose instead of cmake.verbose for scikit-build-core
 DEBUG:       >= 0.10
 DEBUG:
 DEBUG:
 DEBUG: hint: `coincurve` (v20.0.0) was included because `testpluguv` (v0.1.0) depends on `pyln-client` (v26.6.2) which depends on `pyln-proto` (v26.6.2) which depends on `coincurve`
```

This error is caused because coincurve v20 depends on scikit-build-core>=0.9.0 and they did a new release where
using cmake.verbose is no longer a warning but an error. coincurve v21 is using the correct build.verbose but is not
working with python 3.14. So we update coincurve to current master until the next release.

Changelog-None
@madelinevibes madelinevibes merged commit 381c086 into ElementsProject:master Jul 9, 2026
39 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

26.06.x Status::Ready for Review The work has been completed and is now awaiting evaluation or approval.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

python releases broken under python 3.13 and 3.14

2 participants