schemas: remove old deprecations, add missing deprecations/added fields#9136
Merged
madelinevibes merged 1 commit intoMay 20, 2026
Merged
Conversation
daywalker90
added
Status::Ready for Review
daywalker90
force-pushed
the
schema-fixed-2606
branch
2 times, most recently
from
b94286f to
c1f402a
Compare
|
No conflicts |
daywalker90
force-pushed
the
schema-fixed-2606
branch
2 times, most recently
from
665d7cc to
29e6414
Compare
Also made fields not go optional if they are deprecated in the case that their parent is also deprecated. This makes more sense imo when you deprecate a whole command. I added deprecation annotation for the .proto file as well so that later in the convert.rs file it properly annotates everything to allow for deprecated stuff. Also fixed one propagation bug for the added/deprecated fields, that's why there are some additional changes of some fields. Changelog-None
daywalker90
force-pushed
the
schema-fixed-2606
branch
from
29e6414 to
5503861
Compare
Collaborator
Author
|
Updated the .md, restored WaitDetails and removed the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed some newly added fields were missing their added attribute and then i noticed some other things so i went through all of them and cleaned them up as much as i could.
There were some old fields where the deprecation cycle was over but they were not removed. I also checked the c code where the json is constructed to see if they are still present. They were not or behind the deprecation code logic, so it should be fine. I found some related code outside of the json methods for the
delayed_to_usandhtlc_resolutionfeerates, not sure if that needs removal or not.Also made fields not go optional if they are deprecated in the case that their parent is also deprecated. This makes more sense imo when you deprecate a whole command.
I added deprecation annotation for the .proto file as well so that later in the convert.rs file it properly annotates everything to allow for deprecated stuff.
Also fixed one propagation bug for the added/deprecated fields, that's why there are some additional changes of some fields.