splice: Changes for reestablish flow#8818
Closed
ddustin wants to merge 3 commits intoElementsProject:masterfrom
Closed
splice: Changes for reestablish flow#8818ddustin wants to merge 3 commits intoElementsProject:masterfrom
ddustin wants to merge 3 commits intoElementsProject:masterfrom
Conversation
ddustin
force-pushed
the
ddustin/more_tx_abort_checks
branch
from
e19f1a8 to
423339d
Compare
Update log message to match the behavior of the check its logging about. Changelog-None
In some situations Eclair sends CHANNEL_READY before resuming the splice in reestablish. This update allows one of these messages to be processed if it comes in during the splice resume process. Changelog-None
ddustin
force-pushed
the
ddustin/more_tx_abort_checks
branch
from
423339d to
b58edcc
Compare
ddustin
changed the title
tx_abortSplice commands can fail because of external reasons, for example our peer rejecting the splice. These external reasons eat the active `splice_command` so we need to stop storing the `splice_command` in callbacks and instead pull it from the `splice_commands` list which automatically removes the object when its consumed. This corrects a lightningd crash under certain RPC circumstances. Changelog-None
Collaborator
Author
|
Closing in favor of #8817 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In interop with Eclair t-bast believes we’re ignoring
tx_abortduring reestablish. Going through and auditing all the reestablish flows, improving some logs around it and adding checks fortx_abortcoming in beforechannel_reestablish.Changelog-None