Skip to content

Conversation

@ShahanaFarooqui
Copy link
Collaborator

Changelog-None: Fixes error from tools/check-release.sh

Reference Failed Action: https://github.com/ElementsProject/lightning/actions/runs/19561062579

Changelog-None: Fixes error from `tools/check-release.sh`
@ShahanaFarooqui ShahanaFarooqui added this to the v25.12 milestone Nov 22, 2025
@ShahanaFarooqui ShahanaFarooqui changed the title make: Remove printing the version from Makefile make: Remove printing version from Makefile Nov 22, 2025
@rustyrussell
Copy link
Contributor

Can we just filter it out instead? I really like the version printing!

diff --git a/tools/check-release.sh b/tools/check-release.sh
index 90da958a57..85dce03ada 100755
--- a/tools/check-release.sh
+++ b/tools/check-release.sh
@@ -50,7 +50,7 @@ if [ "$HEAD_VERSION" != "$VERSION" ]; then
 fi
 
 # The version tag should match the `make version` target output.
-MAKE_VERSION=$(make version)
+MAKE_VERSION=$(make version | grep -v 'Building version')
 echo "MAKE_VERSION=$MAKE_VERSION"
 if [ "$MAKE_VERSION" != "$VERSION" ]; then
     echo "The version tag must match the \`make version\` target output." >&2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants