Candidate 1.5.5#536
Open
jgriffiths wants to merge 7 commits into
Open
Conversation
node_get_child_count() iterates all keys which we then immediately do again below. Count the children as we iterate checking the keys instead. Co-authored-by: odudex <odudex@proton.me>
Even when building with -fvisibility=hidden, some internal functions (those that aren't static and thus provably limited to a single compilation unit) are not marked hidden. As a result, calls to them from within the library are routed through the PLT. This can result in register data containing secrets/partial secrets being spilled to the stack. Mark such internal functions as hidden so internal calls to them avoid the PLT call mechanism.
In particular when built as a shared library, calls through the PLT spill these registers onto the stack. Thanks to @pythcoiner <pythcoiner@proton.me> for identifying the leak cause and suggesting a fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 1.5.5
Fixed