Eliminate early returns in ConnectBlock #1551
+25
−22
Open
Cirrus CI / lint [bionic]
failed
May 20, 2026 in 3m 27s
Task Summary
Instruction lint failed in 02:07
Details
✅ 00:54 clone
✅ 00:22 merge_base
❌ 02:07 lint
Requirement already satisfied: typing-extensions>=3.7.4 in /usr/local/lib/python3.6/dist-packages (from mypy==0.910)
Collecting toml (from mypy==0.910)
Downloading https://files.pythonhosted.org/packages/44/6f/7120676b6d73228c96e17f1f794d8ab046fc910d781c8d151120c3f1569e/toml-0.10.2-py2.py3-none-any.whl
Building wheels for collected packages: mypy-extensions
Running setup.py bdist_wheel for mypy-extensions: started
Running setup.py bdist_wheel for mypy-extensions: finished with status 'done'
Stored in directory: /root/.cache/pip/wheels/ec/1d/96/19f0b5052e22b513d6f837e7690a6657b20eb0f29da0ebc051
Successfully built mypy-extensions
Installing collected packages: mypy-extensions, typed-ast, toml, mypy
Successfully installed mypy-0.910 mypy-extensions-0.4.4 toml-0.10.2 typed-ast-1.4.3
Collecting pyzmq==22.3.0
Downloading https://files.pythonhosted.org/packages/4b/d3/0cf139d9149bbf3f052b385842afa4e202ea743d85632815d98d0e67685a/pyzmq-22.3.0-cp36-cp36m-manylinux_2_5_x86_64.manylinux1_x86_64.whl (1.1MB)
Installing collected packages: pyzmq
Successfully installed pyzmq-22.3.0
Collecting vulture==2.3
Downloading https://files.pythonhosted.org/packages/a9/68/6dd3fdcbf00a1ca3c74e6e0876cda6c36c27744a7cde3e3b9f95e908b7b5/vulture-2.3-py2.py3-none-any.whl
Requirement already satisfied: toml in /usr/local/lib/python3.6/dist-packages (from vulture==2.3)
Installing collected packages: vulture
Successfully installed vulture-2.3
src/crypto/ctaes in HEAD currently refers to tree 1b6c31139a71f80245c09597c343936a8e41d021
src/crypto/ctaes in HEAD was last updated in commit 8501bedd7508ac514385806e191aec21ee978891 (tree 1b6c31139a71f80245c09597c343936a8e41d021)
GOOD
src/secp256k1 in HEAD currently refers to tree 443b709472fab3c492daca906274af64dd488c7d
src/secp256k1 in HEAD was last updated in commit 3f32c20932341bf67532546fa19261f8cdd17753 (tree 443b709472fab3c492daca906274af64dd488c7d)
GOOD
src/simplicity in HEAD currently refers to tree 762ec16658daeb9d8c2314c3a3dca2d8a02f8a8e
src/simplicity in HEAD was last updated in commit 87c0b44f78a2b42874f8d5a0d63eabd7487c7214 (tree 762ec16658daeb9d8c2314c3a3dca2d8a02f8a8e)
GOOD
src/minisketch in HEAD currently refers to tree a584efdc3ab5184a004807db66381c5c482e5f41
src/minisketch in HEAD was last updated in commit 6e0b07d281af3a41f27d1c41429d8d2bc7ad4bdf (tree a584efdc3ab5184a004807db66381c5c482e5f41)
GOOD
src/univalue in HEAD currently refers to tree 3313812f4165d185703744b9633eadb4109eeb4b
src/univalue in HEAD was last updated in commit 9b49ed656fb2b687fbbe8a3236d18285957eee16 (tree 3313812f4165d185703744b9633eadb4109eeb4b)
GOOD
src/leveldb in HEAD currently refers to tree 52dde68beb13b70f6d5f2b1935c783db89087fc9
src/leveldb in HEAD was last updated in commit 66480821b36c839ab7615cb9309850015bceadb0 (tree 52dde68beb13b70f6d5f2b1935c783db89087fc9)
GOOD
src/crc32c in HEAD currently refers to tree 17db66823db814baeccdb6bf224f85a9869f1fdd
src/crc32c in HEAD was last updated in commit 1d44513f9b34f2a59c794474752025430285a68b (tree 17db66823db814baeccdb6bf224f85a9869f1fdd)
GOOD
Args used : 217
Args documented : 296
Args undocumented: 0
set()
Args unknown : 79
{'-total_valid_epochs', '-txconfirmtarget', '-checkmempool', '-dbbatchsize', '-zmqpubhashtx', '-zmqpubsequencehwm', '-rpcservertimeout', '-mocktime', '-peginconfirmationdepth', '-testnet', '-zmqpubsequence', '-zmqpubrawtxhwm', '-rpcworkqueue', '-con_npowtargettimespan', '-npruneafterheight', '-con_csv_deploy_start', '-maxtimeadjustment', '-checklevel', '-maxsigcachesize', '-initialfreecoins', '-dbcrashratio', '-dynamic_epoch_length', '-maxreceivebuffer', '-zmqpubrawblock', '-con_nminerconfirmationwindow', '-blockmaxweight', '-con_npowtargetspacing', '-zmqpubrawtx', '-zmqpubhashblock', '-blockversion', '-rpcclienttimeout', '-maxconnections', '-rpcport', '-con_max_block_sig_size', '-bantime', '-ct_exponent', '-peginsubsidyheight', '-limitancestorcount', '-datacarriersize', '-mempoolexpiry', '-maxmempool', '-rpcthreads', '-signet', '-blockreconstructionextratxn', '-limitancestorsize', '-limitdescendantcount', '-ct_bits', '-con_nsubsidyhalvinginterval', '-zmqpubhashtxhwm', '-maxsendbuffer', '-con_bip65height', '-dblogsize', '-timeout', '-peertimeout', '-con_bip34height', '-limitdescendantsize', '-mainchainrpcport', '-maxtipage', '-initialreissuancetokens', '-stopatheight', '-con_blocksubsidy', '-zmqpubrawblockhwm', '-con_bip66height', '-maxorphantx', '-fallback_fee_enabled', '-con_connect_genesis_outputs', '-con_nrulechangeactivationthreshold', '-rpcserialversion', '-mainchainrpctimeout', '-regtest', '-zmqpubhashblockhwm', '-includeconf', '-checkaddrman', '-peginminheight', '-rpcwaittimeout', '-con_start_p2wsh_script', '-bytespersigop', '-min_time', '-checkblocks'}
All calls to LogPrintf() and LogPrint() should be terminated with \n
src/validation.cpp: LogPrintf("Block validation error: %s", state.ToString());
^---- failure generated from test/lint/lint-logs.sh
Success: no issues found in 266 source files
src/logging.cpp:398: supressed ==> suppressed
src/logging.cpp:411: supressed ==> suppressed
src/test/logging_tests.cpp:238: supression ==> suppression
src/test/logging_tests.cpp:255: supression ==> suppression
^ Warning: codespell identified likely spelling errors. Any false positives? Add them to the list of ignored words in test/lint/lint-spelling.ignore-words.txt
Loading