Skip to content

fix(cli): replace all hyphens in shell completion command names #6213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lihan3238 wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −2
Open

fix(cli): replace all hyphens in shell completion command names #6213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c229bc
fix(cli): replace all hyphens in shell completion command names
lihan3238 May 5, 2026
345ce6d
add changeset
lihan3238 May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-cli-completions-hyphen.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@effect/cli": patch
---

fix(cli): replace all hyphens in shell completion command names
4 changes: 2 additions & 2 deletions packages/cli/src/internal/commandDescriptor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1081,7 +1081,7 @@ const getBashCompletionsInternal = (
: pipe(
info.parentCommands,
Arr.append(info.command.name),
Arr.map((command) => command.replace("-", "__"))
Arr.map((command) => command.replaceAll("-", "__"))
)
const caseName = Arr.join(preformatted, ",")
const funcName = Arr.join(preformatted, "__")
Expand Down Expand Up @@ -1238,7 +1238,7 @@ const getZshCompletionsInternal = (
: pipe(
info.parentCommands,
Arr.append(info.command.name),
Arr.map((command) => command.replace("-", "__"))
Arr.map((command) => command.replaceAll("-", "__"))
)
const underscoreName = Arr.join(preformatted, "__")
const spaceName = Arr.join(preformatted, " ")
Expand Down
Loading