fix(opentelemetry): make sdk-trace-node and sdk-trace-web required peer deps #5952
+5
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayroach
requested review from
IMax153,
gcanti,
mattiamanzati,
mikearnaldi and
tim-smart
as code owners
🦋 Changeset detectedLatest commit: b713b28 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
clayroach
force-pushed
the
fix/opentelemetry-optional-peer-deps
branch
2 times, most recently
from
ac92bde to
9fe789e
Compare
Member
|
we should make them peer dependencies instead of optional, cc @tim-smart |
…er deps Remove optional flag from @opentelemetry/sdk-trace-node and @opentelemetry/sdk-trace-web peer dependencies. This fixes module resolution errors when importing from the main entry point, since ESM static imports require these packages to be installed.
clayroach
force-pushed
the
fix/opentelemetry-optional-peer-deps
branch
from
9fe789e to
b713b28
Compare
clayroach
changed the title
Author
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
@effect/opentelemetrymarks@opentelemetry/sdk-trace-nodeand@opentelemetry/sdk-trace-webas optional peer dependencies. However, both are exported from the mainindex.ts, which creates static ESM imports. This causes module resolution errors when users don't have these packages installed:Solution
Make
@opentelemetry/sdk-trace-nodeand@opentelemetry/sdk-trace-webrequired peer dependencies by removing them frompeerDependenciesMeta.Changes
optional: truefor@opentelemetry/sdk-trace-nodeoptional: truefor@opentelemetry/sdk-trace-webTesting