-
-
Notifications
You must be signed in to change notification settings - Fork 490
Add Cron.prev reverse iteration support #5786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 42e9d0d The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@copilot tell me I'm beautiful |
|
@kitlangton I've opened a new pull request, #5787, to work on those changes. Once the pull request is ready, I'll request review from you. |
6c3c7b6 to
a75f668
Compare
1b1867b to
7144657
Compare
7922be1 to
8fa279a
Compare
|
Any chance this can get merged? Would love to drop another dependency in favor of Effect. |
|
@fubhy YOU HAVE DECEIVED US. |
|
OKOK I AM ON IT! |
fubhy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to team Cron
Co-authored-by: Tom MacWright <tom@macwright.com> Co-authored-by: Sebastian Lorenz <fubhy@fubhy.com>
Summary
Context
Based on @tmcw's fork branch https://github.com/tmcw/effect/tree/cron-prev ; rebased on main and tightened tests/edge cases.
Closes #5666.
Testing