fix(ios): force fmt to c++17 for Xcode 26#5997
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f4e8c87. Configure here.
a1d8fad to
abc3f78
Compare
Contributor
|
Attempt to find a future proof solution for post RN upgrade. If not possible, just merge |
76c62e4 to
abc3f78
Compare
Newer Apple Clang toolchains fail to compile fmt 11.0.2 under C++20 with consteval-related errors, blocking simulator builds on Xcode 26. Keep the workaround in Podfile post_install so pod regeneration consistently reapplies FMT_USE_CONSTEVAL=0 and fmt-specific C++17 settings instead of requiring manual edits in Pods/.
abc3f78 to
1394f3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Newer Apple Clang toolchains fail to compile fmt 11.0.2 under C++20 with consteval-related errors, blocking simulator builds on Xcode 26.
Keep the workaround in Podfile post_install so pod regeneration consistently reapplies FMT_USE_CONSTEVAL=0 and fmt-specific C++17 settings instead of requiring manual edits in Pods/.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Medium Risk
Touches iOS CocoaPods
post_installbuild settings and forces C++ flags, which could affect native pod compilation/linking across configs even though it’s a targeted workaround.Overview
Keeps Xcode simulator/device builds working on newer Apple Clang toolchains by adding CocoaPods
post_installoverrides for thefmtdependency.This globally adds
FMT_USE_CONSTEVAL=0to pod preprocessor definitions, and afterreact_native_post_installre-appliesfmt-specific C++17 settings (including updating generated.xcconfigvalues) so the workaround persists acrosspod installregenerations.Updates
Podfile.lockchecksum accordingly.Reviewed by Cursor Bugbot for commit 1394f3d. Bugbot is set up for automated code reviews on this repo. Configure here.