Skip to content

Conversation

@samholmes
Copy link
Contributor

@samholmes samholmes commented Nov 11, 2025

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Note

Replaces exchangeAmount with new amountQuery (exact/max/maxExchangeAmount) across UI and ramp plugins, adding crypto-amount and robust MAX flow support (with caps) notably for Infinite.

  • Types/Core:
    • Replace RampQuoteRequest.exchangeAmount with amountQuery using RampQouteAmount (exchangeAmount | max | maxExchangeAmount).
    • Update all providers to consume amountQuery; remove references to RampExchangeAmount.
  • UI (src/components/scenes/RampCreateScene.tsx):
    • Migrate state and logic to amountQuery; adjust initial amount, MAX handling, and navigation auto-advance for max.
    • Rework display amount calculations, insufficient funds checks, and button/quote enablement to use amountQuery and maxExchangeAmount.
  • Providers:
    • Infinite (infiniteRampPlugin.ts):
      • checkSupport now reports supportedAmountTypes: ['fiat','crypto'].
      • fetchQuotes supports fiat/crypto amount types, MAX and capped MAX, validates against min/max, and builds source/target params accordingly; maps response amounts safely; updates dev test path.
    • Banxa/Moonpay/Paybis/Revolut/Simplex:
      • Read amountQuery (exchangeAmount/max/maxExchangeAmount) for quotes; apply appropriate limit checks and MAX-cap logic.
  • Misc:
    • Minor guard/derivation updates (e.g., rate display gating, max-quote picking) to align with new amount model.

Written by Cursor Bugbot for commit 1f7fb6f. This will update automatically on new commits. Configure here.


@samholmes
Copy link
Contributor Author

samholmes commented Nov 12, 2025

@swansontec I'm okay with removing some of the refactor for staging and instead punt it to develop if you don't think its safe enough

Copy link
Contributor

@swansontec swansontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One AI comment should be looked at, but overall this is a good improvement.

@samholmes samholmes force-pushed the sam/infinite-ramp-max branch from 1de63e6 to 0a43399 Compare November 14, 2025 19:42
@samholmes samholmes force-pushed the sam/infinite-ramp-max branch from 0a43399 to 1f7fb6f Compare November 14, 2025 21:37
@samholmes samholmes merged commit cfd226b into develop Nov 14, 2025
3 checks passed
@samholmes samholmes deleted the sam/infinite-ramp-max branch November 14, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants