Angular 22 - #198
Merged
Merged
Conversation
Amongst other things, this update eslint and their rules, helping us prepare for incoming Angular 22.
Except: - @types/node, we run on node 22 - typescript, angular is not ready
Was added by Angular migration but is not neccessary for us
There was a problem hiding this comment.
Pull request overview
Upgrades the frontend to Angular 22 and its compatible TypeScript, GraphQL, linting, and UI dependencies.
Changes:
- Migrates dependency injection and GraphQL code generation to updated APIs.
- Adapts router, compiler, imports, and change-detection configuration.
- Explicitly enables eager change detection across components, conflicting with the required OnPush strategy.
Reviewed changes
Copilot reviewed 107 out of 109 changed files in this pull request and generated 78 comments.
Show a summary per file
| File | Description |
|---|---|
tsconfig.json |
Updates Angular 22 compiler settings. |
package.json |
Upgrades Angular and supporting dependencies. |
codegen.ts |
Migrates GraphQL code generation configuration. |
client/app/app.config.ts |
Adopts Angular 22 router defaults. |
client/app/app.component.ts |
Adds eager change detection. |
client/app/configuration/services/configuration.service.ts |
Migrates to @Service. |
client/app/shared/testing/MockApolloProvider.ts |
Migrates mock provider to @Service. |
client/app/shared/services/permissions.service.ts |
Migrates to @Service. |
client/app/shared/services/logger-extra.service.ts |
Migrates to @Service. |
client/app/shared/services/localized-paginator-intl.service.ts |
Migrates to @Service. |
client/app/shared/services/currency.service.ts |
Migrates to @Service. |
client/app/shared/components/address/country.service.ts |
Migrates to @Service. |
client/app/shared/components/address/address.component.ts |
Adds eager change detection. |
client/app/shared/components/tags-navigation/tags-navigation.component.ts |
Adds eager change detection. |
client/app/shared/components/price/price.component.ts |
Adds eager change detection. |
client/app/shared/components/error/error.component.ts |
Adds eager change detection. |
client/app/shared/components/breadcrumbs/breadcrumbs.component.ts |
Adds eager change detection. |
client/app/shared/components/boot-loader/boot-loader.component.ts |
Adds eager change detection. |
client/app/user/components/request-password-reset/request-password-reset.component.ts |
Adds eager change detection. |
client/app/user/components/register/register.component.ts |
Adds eager change detection. |
client/app/user/components/register/register-confirm.component.ts |
Adds eager change detection. |
client/app/user/components/password/password.component.ts |
Adds eager change detection. |
client/app/user/components/change-password/change-password.component.ts |
Adds eager change detection. |
client/app/profile/components/purchases/purchases.component.ts |
Adds eager change detection. |
client/app/profile/components/purchases/purchase.service.ts |
Migrates to @Service. |
client/app/profile/components/profile/profile.component.ts |
Adds eager change detection. |
client/app/profile/components/history/history.component.ts |
Adds eager change detection. |
client/app/profile/components/account/account.component.ts |
Adds eager change detection. |
client/app/front-office/services/navigation.service.ts |
Migrates to @Service. |
client/app/front-office/front-office.component.ts |
Adds eager change detection. |
client/app/front-office/modules/shop/components/subscriptions/subscriptions.component.ts |
Adds eager change detection. |
client/app/front-office/modules/shop/components/subscriptions/subscription.service.ts |
Migrates to @Service. |
client/app/front-office/modules/shop/components/products-page/products-page.component.ts |
Adds eager change detection. |
client/app/front-office/modules/shop/components/product-page/product-page.component.ts |
Adds eager change detection. |
client/app/front-office/modules/shop/components/emails/emails.component.ts |
Adds eager change detection. |
client/app/front-office/modules/shop/components/add-to-cart/add-to-cart.component.ts |
Adds eager change detection. |
client/app/front-office/modules/cart/services/global-cart.service.ts |
Migrates to @Service. |
client/app/front-office/modules/cart/services/datatrans.service.ts |
Migrates to @Service. |
client/app/front-office/modules/cart/services/cart.service.ts |
Migrates to @Service. |
client/app/front-office/modules/cart/services/cart-collection.service.ts |
Migrates to @Service. |
client/app/front-office/modules/cart/components/create-order/create-order.component.ts |
Adds eager change detection. |
client/app/front-office/modules/cart/components/cart/cart.component.ts |
Adds eager change detection. |
client/app/front-office/components/soutenir/rejoindre-association/rejoindre-association.component.ts |
Adds eager change detection. |
client/app/front-office/components/soutenir/offrir-la-revue/offrir-la-revue.component.ts |
Adds eager change detection. |
client/app/front-office/components/soutenir/nous-faire-connaitre/nous-faire-connaitre.component.ts |
Adds eager change detection. |
client/app/front-office/components/sessions-incoming/sessions-incoming.component.ts |
Adds eager change detection. |
client/app/front-office/components/session-side-column/session-side-column.component.ts |
Adds eager change detection. |
client/app/front-office/components/session-organisation/session-organisation.component.ts |
Adds eager change detection. |
client/app/front-office/components/session-method/session-method.component.ts |
Adds eager change detection. |
client/app/front-office/components/session-facilitator/session-facilitator.component.ts |
Adds eager change detection. |
client/app/front-office/components/session-facilitator-private/session-facilitator-private.component.ts |
Adds eager change detection. |
client/app/front-office/components/projet/projet.component.ts |
Adds eager change detection. |
client/app/front-office/components/points-de-vente/points-de-vente.component.ts |
Adds eager change detection. |
client/app/front-office/components/newses-page/newses-page.component.ts |
Adds eager change detection. |
client/app/front-office/components/news-page/news-page.component.ts |
Adds eager change detection. |
client/app/front-office/components/login/login.component.ts |
Adds eager change detection. |
client/app/front-office/components/legal-mentions/legal-mentions.component.ts |
Adds eager change detection. |
client/app/front-office/components/homepage/homepage.component.ts |
Adds eager change detection. |
client/app/front-office/components/home-block/home-block.component.ts |
Adds eager change detection. |
client/app/front-office/components/faire-un-don/faire-un-don.component.ts |
Adds eager change detection. |
client/app/front-office/components/events-page/events-page.component.ts |
Adds eager change detection. |
client/app/front-office/components/event-page/event-page.component.ts |
Adds eager change detection. |
client/app/front-office/components/donation/donation.component.ts |
Adds eager change detection. |
client/app/front-office/components/contact/contact.component.ts |
Adds eager change detection. |
client/app/front-office/components/conditions-generales-vente/conditions-generales-vente.component.ts |
Adds eager change detection. |
client/app/front-office/components/circuits-courts/circuits-courts.component.ts |
Adds eager change detection. |
client/app/front-office/components/association/qui-sommes-nous/qui-sommes-nous.component.ts |
Adds eager change detection. |
client/app/front-office/components/association/partenariats/partenariats.component.ts |
Adds eager change detection. |
client/app/front-office/components/association/convictions/convictions.component.ts |
Adds eager change detection. |
client/app/front-office/components/association/comite-status/comite-status.component.ts |
Adds eager change detection. |
client/app/front-office/components/agir-avec-nous/rapport-epiceries-alternatives/rapport-epiceries-alternatives.component.ts |
Adds eager change detection. |
client/app/front-office/components/agir-avec-nous/numerique-ethique/numerique-ethique.component.ts |
Adds eager change detection. |
client/app/front-office/components/agir-avec-nous/irremplacables-epiceries/irremplacables-epiceries.component.ts |
Adds eager change detection. |
client/app/front-office/components/agir-avec-nous/desinvestir-fossile/desinvestir-fossile.component.ts |
Adds eager change detection. |
client/app/front-office/components/agir-avec-nous/bns/bns.component.ts |
Adds eager change detection. |
client/app/front-office/components/agir-avec-nous/alimentation/alimentation.component.ts |
Adds eager change detection. |
client/app/front-office/components/agir-avec-nous/agir-au-quotidien/agir-au-quotidien.component.ts |
Adds eager change detection. |
client/app/front-office/components/agir-avec-nous/actions/actions.component.ts |
Adds eager change detection. |
client/app/admin/admin/admin.component.ts |
Adds eager change detection. |
client/app/admin/users/users/users.component.ts |
Adds eager change detection. |
client/app/admin/users/user/user.component.ts |
Adds eager change detection. |
client/app/admin/users/services/user.service.ts |
Migrates to @Service. |
client/app/admin/users/services/user.service.spec.ts |
Replaces a base-URL-dependent import. |
client/app/admin/users/import/import.component.ts |
Adds eager change detection. |
client/app/admin/sessions/sessions/sessions.component.ts |
Adds eager change detection. |
client/app/admin/sessions/session/session.component.ts |
Adds eager change detection. |
client/app/admin/sessions/services/session.service.ts |
Migrates to @Service. |
client/app/admin/products/services/product.service.ts |
Migrates to @Service. |
client/app/admin/products/services/image.service.ts |
Migrates to @Service. |
client/app/admin/products/products/products.component.ts |
Adds eager change detection. |
client/app/admin/products/product/product.component.ts |
Adds eager change detection. |
client/app/admin/product-tags/services/product-tag.service.ts |
Migrates to @Service. |
client/app/admin/order/services/order.service.ts |
Migrates to @Service. |
client/app/admin/order/services/order-lines.service.ts |
Migrates to @Service. |
client/app/admin/order/orders/orders.component.ts |
Adds eager change detection. |
client/app/admin/order/order/order.component.ts |
Adds eager change detection. |
client/app/admin/order/order-lines/order-lines.component.ts |
Adds eager change detection. |
client/app/admin/order/order-line/order-line.component.ts |
Adds eager change detection. |
client/app/admin/newses/services/news.service.ts |
Migrates to @Service. |
client/app/admin/newses/newses/newses.component.ts |
Adds eager change detection. |
client/app/admin/newses/news/news.component.ts |
Adds eager change detection. |
client/app/admin/files/services/files.service.ts |
Migrates to @Service. |
client/app/admin/facilitator-documents/services/facilitator-documents.service.ts |
Migrates to @Service. |
client/app/admin/facilitator-documents/facilitator-documents/facilitator-documents.component.ts |
Adds eager change detection. |
client/app/admin/facilitator-documents/facilitator-document/facilitator-document.component.ts |
Adds eager change detection. |
client/app/admin/events/services/event.service.ts |
Migrates to @Service. |
client/app/admin/events/events/events.component.ts |
Adds eager change detection. |
client/app/admin/events/event/event.component.ts |
Adds eager change detection. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ], | ||
| templateUrl: './request-password-reset.component.html', | ||
| styleUrl: './request-password-reset.component.scss', | ||
| changeDetection: ChangeDetectionStrategy.Eager, |
| imports: [NgProgressbar, RouterOutlet, BootLoaderComponent], | ||
| templateUrl: './app.component.html', | ||
| styleUrl: './app.component.scss', | ||
| changeDetection: ChangeDetectionStrategy.Eager, |
| ], | ||
| templateUrl: './purchases.component.html', | ||
| styleUrl: './purchases.component.scss', | ||
| changeDetection: ChangeDetectionStrategy.Eager, |
| ], | ||
| templateUrl: './history.component.html', | ||
| styleUrl: './history.component.scss', | ||
| changeDetection: ChangeDetectionStrategy.Eager, |
| ], | ||
| templateUrl: './password.component.html', | ||
| styleUrl: './password.component.scss', | ||
| changeDetection: ChangeDetectionStrategy.Eager, |
| imports: [AddToCartComponent], | ||
| templateUrl: './rejoindre-association.component.html', | ||
| styleUrl: './rejoindre-association.component.scss', | ||
| changeDetection: ChangeDetectionStrategy.Eager, |
| selector: 'app-nous-faire-connaitre', | ||
| templateUrl: './nous-faire-connaitre.component.html', | ||
| styleUrl: './nous-faire-connaitre.component.scss', | ||
| changeDetection: ChangeDetectionStrategy.Eager, |
| selector: 'app-comite-status', | ||
| templateUrl: './comite-status.component.html', | ||
| styleUrl: './comite-status.component.scss', | ||
| changeDetection: ChangeDetectionStrategy.Eager, |
| imports: [MatButton, RouterLink], | ||
| templateUrl: './offrir-la-revue.component.html', | ||
| styleUrl: './offrir-la-revue.component.scss', | ||
| changeDetection: ChangeDetectionStrategy.Eager, |
| ], | ||
| templateUrl: './donation.component.html', | ||
| styleUrl: './donation.component.scss', | ||
| changeDetection: ChangeDetectionStrategy.Eager, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.