Repository navigation
feat: plugin API 8 (nevr-runtime v5.18.0's header, check_mod accepts "api": 8) - #6
Open
marshmallow-mia wants to merge 1 commit into
Open
marshmallow-mia wants to merge 1 commit into
marshmallow-mia wants to merge 1 commit into
Conversation
…"api": 8) nevr-runtime v5.15.0 (#1105) added the game's main level to every context as API v8: level_symbol and level_name at the tail of NvrGameContext, plus the Quest additions after them (game_build_id, NEVR_HOST_PLATFORM_QUEST). A mod that reads them declares "api": 8, which check_mod.py refused. - include/nevr_plugin_interface.h: re-copied from nevr-runtime's src/extension/plugin_interface.h at v5.18.0 (6609d425); the template's NEVR_CTX_HAS and static_asserts kept, with the v8 offset (level_symbol at 64) and the context's size (88) asserted. - tools/check_mod.py: "api" 5 to 8. - tests: 5-8 pass, 4 and 9 are refused. Checked: the MinGW build (static_asserts hold), the 38 tests, check_mod.py on the built DLL, and an "api": 8 copy built with -DECHO_MOD_ASSET_EXAMPLE=ON passing check_mod.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nevr-runtime v5.15.0 (#1105) added the game's main level to every context as API v8:
level_symbolandlevel_nameat the tail ofNvrGameContext, plus the Quest additions after them (game_build_id,NEVR_HOST_PLATFORM_QUEST). A mod that reads them declares"api": 8, whichcheck_mod.pyrefused.include/nevr_plugin_interface.h: re-copied from nevr-runtime'ssrc/extension/plugin_interface.hat v5.18.0 (6609d425); the template'sNEVR_CTX_HASand static_asserts kept, with the v8 offset (level_symbolat 64) and the context's size (88) asserted.tools/check_mod.py:"api"5 to 8.Checked:
check_mod.pyon the built DLL;"api": 8copy built with-DECHO_MOD_ASSET_EXAMPLE=ONpassingcheck_mod.py.