Skip to content

chore(media): Don't suppress original exception in ManifestDecodeError #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tehkillerbee merged 1 commit into from
Jan 15, 2026
+6 −6
Merged

chore(media): Don't suppress original exception in ManifestDecodeError #397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tidalapi/media.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,8 +609,8 @@ def get_manifest_data(self) -> str:
try:
# Stream Manifest is base64 encoded.
return base64.b64decode(self.manifest).decode("utf-8")
except:
raise ManifestDecodeError
except Exception as e:
raise ManifestDecodeError from e

@property
def is_mpd(self) -> bool:
Expand Down Expand Up @@ -761,15 +761,15 @@ def from_stream(stream) -> "DashInfo":
try:
if stream.is_mpd and not stream.is_encrypted:
return DashInfo(stream.get_manifest_data())
except:
raise ManifestDecodeError
except Exception as e:
raise ManifestDecodeError from e

@staticmethod
def from_mpd(mpd_manifest) -> "DashInfo":
try:
return DashInfo(mpd_manifest)
except:
raise ManifestDecodeError
except Exception as e:
raise ManifestDecodeError from e

def __init__(self, mpd_xml):
mpd = MPEGDASHParser.parse(
Expand Down