Repository navigation
Conversation
glaze 9 uses `emit` as an identifier, which Qt defines as a macro: hide the macro around the glaze includes. The Editor takes an optional project folder argument (EasyRPG or RPG Maker 2000/2003); without one it opens the last project as before.
|
Looks good to me thx Fyi the editor is being migrated from QWidgets to Qml as this is the modern way to design Uis these days. So don't invest too much time on Widgets as it's slowly phased out. Some components can be reused such as QGraphicsViews. Pls not too many pull requests that touch widget stuff :). (What you do in a work is up to you.) |
|
Thank you for the tip! That's good to know. Of course. I want to respect your work and you seem to have your own goals for this project (saw the other PR about dynamic layout, looks fantastic). Do you want me to remove the project path parameter from the scope of this PR? |
|
No no that PR is fine. In general everything that doesn't touch the widgets is fine as the data structure in the background (lcf database etc) stays the same. (And minor bug fixes for widgets are okay just no huge new features) I also saw this rmsync code you wrote which looks like some interesting software. |
|
btw. this will be fixed in next version: stephenberry/glaze#2977 |
|
@carstene1ns this is great news! Once the fix is deployed, we can close this PR and update the glaze dep. 9.0.0 was released 3 weeks ago and the fix was merged 2 weeks ago, this shouldn't take too long. @Ghabry For sure. With reverse engineering becoming mainstream, your guidance and expertise is more important than ever. rpgsync synchronizes the RPG Maker code to python scripts. It let me 1. add version control to event code, 2. run test suites on event code, 3. automatize operations on dialogs (translation, statistics, coherence checks), 4. let agents refacto my spaghetti code (or deal with the spaghetti code, hehe). I've used it on my game and got more done in 24 hours than in years. When you come back from your software engineer job to work on your passion project, it's hard to be brought back 30 years ago in terms of developper experience. My goal is to upgrade the RPG Maker tooling to match industry's standards, so we can all finally finish our games lol. I'd love to contribute more to the EasyRPG Editor in a way that's respectful of the historical work and direction. For now, happy to be the guinea pig to figure out what works and what doesn't. |
Hello!
Thank you again for putting this together. Had a blast tinkering with this repo the past few days.
This PR fixes a compiler issue related to a symbol confusion, that prevents CICD from running
It also adds a way to choose a starting project from the CLI (useful for testing).
Hope this helps!