TSM-11: convert Group A models to TypeScript - #568
Open
Justin Hammond (Justintime50) wants to merge 13 commits into
Open
TSM-11: convert Group A models to TypeScript#568Justin Hammond (Justintime50) wants to merge 13 commits into
Justin Hammond (Justintime50) wants to merge 13 commits into
Conversation
Justin Hammond (Justintime50)
changed the title
Justin Hammond (Justintime50)
force-pushed
the
ts-migrate/11-models-group-a
branch
from
August 11, 2026 16:35
42131e9 to
5bc92af
Compare
Justin Hammond (Justintime50)
force-pushed
the
ts-migrate/11-models-group-a
branch
from
August 11, 2026 17:20
5bc92af to
05ce465
Compare
Justin Hammond (Justintime50)
marked this pull request as ready for review
August 12, 2026 20:27
| * @extends EasyPostObject | ||
| */ | ||
| export default class Address extends EasyPostObject { | ||
| declare street1?: string | null; |
There was a problem hiding this comment.
If ? denotes an optional value why do you need to type these as string | null instead of just string?
There was a problem hiding this comment.
never mind I forgot about undefined
Steven Roomberg (sroomberg-ep)
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation