Repository navigation
Conversation
The type and operators of the field structure are now substituted with <= instead of <-, so that ZModpField keeps them and can be passed as a theory, e.g. theory IDCoeff <- ZModpField when cloning Poly.Poly.
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Ring.FieldcloneZModpFieldintheories/algebra/ZModP.ecnow uses<=substitutions, asZModpRingalready does. This keeps its type and operators as definitions, soZModpFieldcan be given for a field or integral-domain theory parameter, e.g.clone Poly.Poly with type coeff <- zmod, theory IDCoeff <- ZModpField.All of
stdlibandexamplesstill check. First of a stack (split from #1233 as suggested in review): this PR, then #1233 (Pocklington), then #1237 (ChaChaPoly).