Skip to content

Conversation

@alperaltuntas
Copy link
Member

@alperaltuntas alperaltuntas commented Dec 15, 2025

Description

The --non-local option for case.setup is currently broken for compsets including CAM.

The issue arises because cam.case_setup does not receive the non_local flag, and it instantiates Case objects without this flag. This PR passes the non_local option to cam.case_setup to fix this issue.

This PR should be evaluated and merged in conjunction with the CAM PR: ESCOMP/CAM#1456

Checklist

  • My code follows the style guidlines of this proejct (black formatting)
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that excerise my feature/fix and existing tests continue to pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding additions and changes to the documentation

@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@5f6a6a8). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4904   +/-   ##
=========================================
  Coverage          ?   31.44%           
=========================================
  Files             ?      264           
  Lines             ?    38703           
  Branches          ?     8390           
=========================================
  Hits              ?    12172           
  Misses            ?    25291           
  Partials          ?     1240           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@jedwards4b jedwards4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants