Fix constants that were missing . in _r8 declarations - #1661
Open
cacraigucar wants to merge 2 commits into
Open
Fix constants that were missing . in _r8 declarations #1661cacraigucar wants to merge 2 commits into
cacraigucar wants to merge 2 commits into
Conversation
jimmielin
reviewed
Aug 25, 2026
jimmielin
left a comment
jimmielin
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @cacraigucar! The CAM .F90 changes look good to me, but I had some suggestions on the script's robustness.
| echo "${sepstr}" | tee -a ${logfile} | ||
| ark_file="/fs/cgd/csm/tools/addrealkind/addrealkind" | ||
| tr8_script="${CAM_ROOT}/test/system/TR8.sh" | ||
| tr8_script="${CAM_ROOT}/test/system/TR8_enhanced.sh" |
Collaborator
There was a problem hiding this comment.
I wonder if we should remove TR8.sh now that it is unused or replace it entirely with the "enhanced" version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any constant that is declared without a
.oreis defined as an integer even when it it has_r8as its kind type. This can lead to integer arithmetic if other variables are integers as well.