Automatic dynamics-splitting defaults to the SE dycore + clean-up - #1656
Open
PeterHjortLauritzen wants to merge 8 commits into
Open
Automatic dynamics-splitting defaults to the SE dycore + clean-up#1656PeterHjortLauritzen wants to merge 8 commits into
PeterHjortLauritzen wants to merge 8 commits into
Conversation
nusbaume
approved these changes
Aug 25, 2026
nusbaume
left a comment
nusbaume
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @PeterHjortLauritzen! I have a few optional requests, but otherwise everything looks good to me.
| M src/dynamics/se/dycore/se_dyn_time_mod.F90 | ||
| - remove variable_nsplit plumbing | ||
| M src/dynamics/se/dycore/control_mod.F90 | ||
| - remove variable_nsplit |
Collaborator
There was a problem hiding this comment.
Might update this slightly:
Suggested change
| - remove variable_nsplit | |
| - remove 'variable_nsplit' and other unused control variables. |
| @@ -33,8 +33,6 @@ module fvm_mod | |||
| type (EdgeBuffer_t), public :: ghostBufQ1_vh | |||
| ! type (EdgeBuffer_t), private :: ghostBufFlux_h | |||
Collaborator
There was a problem hiding this comment.
Remove commented-out line of code here?
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
PeterHjortLauritzen
force-pushed
the
namelist_defaults
branch
from
August 25, 2026 20:59
0007dd7 to
3e26f96
Compare
Collaborator
Author
|
Thanks Jesse ... suggestions adopted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #969
closes #1655