Add check for the existence of EESSI_SITE_SOFTWARE_PATH in EESSI-extend#235
Draft
casparvl wants to merge 2 commits into
Draft
Add check for the existence of EESSI_SITE_SOFTWARE_PATH in EESSI-extend#235casparvl wants to merge 2 commits into
EESSI_SITE_SOFTWARE_PATH in EESSI-extend#235casparvl wants to merge 2 commits into
Conversation
…needed if we make this location configurable thourhg EESSI_SITE_SOFTWARE_PREFIX as is done in EESSI#232
Contributor
Author
|
bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws for:arch=x86_64/amd/zen2 |
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
|
New job on instance
|
ocaisa
requested changes
May 26, 2026
| if not isDir(easybuild_installpath) then | ||
| LmodError("The location of EESSI_SITE_SOFTWARE_PATH (" .. easybuild_installpath .. ") does not exist or is not a folder") | ||
| end | ||
| -- enforce accelerator subdirectory usage for site installs (only if an accelerator install is requested) |
Member
There was a problem hiding this comment.
Suggested change
| -- enforce accelerator subdirectory usage for site installs (only if an accelerator install is requested) | |
| -- enforce accelerator subdirectory usage for site installs (only if an accelerator install is requested) |
Comment on lines
+147
to
+149
| if not isDir(easybuild_installpath) then | ||
| LmodError("The location of EESSI_SITE_SOFTWARE_PATH (" .. easybuild_installpath .. ") does not exist or is not a folder") | ||
| end |
Member
There was a problem hiding this comment.
EasyBuild will happily create the folder later on first run (if it is allowed), could just be a warning
| easybuild_installpath = pathJoin(easybuild_installpath, eessi_accelerator_target) | ||
| -- Check that the EESSI_SITE_SOFTWARE_PATH with eessi_accelerator_target prefix exists | ||
| if not isDir(easybuild_installpath) then | ||
| LmodError("The easybuild install directory (" .. easybuild_installpath ..") does not exist or is not a folder") |
Member
There was a problem hiding this comment.
Same here, it doesn't have to exist.
The site paths are special because they are exposed by default. I'll need to check the other PR to make sure there is no check for their existence before adding them to MODULEPATH...when I build something for the site I expect everyone to see it even if their session started before the path existed. Lmod is fine with adding non-existent paths.
Member
|
Oh, reading the initial comment it seems I asked for this. I wonder what I asked for...or more accurately what I think I meant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add check for the existence of the
EESSI_SITE_SOFTWARE_PATH. This is needed if we make this location configurable throughEESSI_SITE_SOFTWARE_PREFIXas is done in #232Edit: hmmm, this check was requested by @ocaisa . But now that I see the CI failing because the dir doesn't exist, I'm wonderig... this means that sites would have to precreate the dir, before they even set
EESSI_SITE_INSTALL=1, or the module will just flat-out fail to load. Is that what we want? If that dir does not exist whenEESSI-extendis loaded, how bad is that? Won't EasyBuild just try to create it? It looks like it...