-
Notifications
You must be signed in to change notification settings - Fork 24
feat: allow symfony 8 and bump min versions #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
allow symfony 8
allow symfony 8
allow symfony 8
allow symfony 8
WalkthroughUpgrade CI workflows (update checkout action, PHP/Symfony matrix entries), bump Symfony and other dependency constraints in composer.json, trim obsolete Doctrine comments in test config, and add two test comment lines; no public API changes. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
allow symfony 8
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #160 +/- ##
============================================
- Coverage 81.96% 81.29% -0.67%
Complexity 292 292
============================================
Files 30 30
Lines 1303 1219 -84
============================================
- Hits 1068 991 -77
+ Misses 235 228 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
allow symfony 8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
composer.json(3 hunks)
🧰 Additional context used
🪛 GitHub Actions: Code_Checks
composer.json
[error] 1-1: Composer dependency resolution failed during 'composer update'. knplabs/knp-time-bundle v2.4.0 requires Symfony Dependency Injection ^5.4|^6.0|^7.0, but constraints present cause a conflict; Your requirements could not be resolved to an installable set of packages.
🔇 Additional comments (3)
composer.json (3)
79-79: Memory limit increase for phpstan is reasonable.Increasing phpstan's memory limit from the default to 2048M is appropriate for analyzing larger codebases.
93-94: No action needed onminimum-stabilitysetting.The
"dev"minimum-stability is intentional and appropriate for a bundle supporting newly-released Symfony 8.0, where some dependencies may not have stable releases yet. Combined withprefer-stable: true, this allows necessary dev versions while still preferring stable releases.
21-21: > Likely an incorrect or invalid review comment.
| "doctrine/persistence": "^3.4.1 || ^4.1", | ||
| "dragonmantank/cron-expression": "^3.4", | ||
| "dragonmantank/cron-expression": "^3.6", | ||
| "knplabs/knp-time-bundle": "^2.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
knplabs/knp-time-bundle Symfony 8 compatibility versions
💡 Result:
Short answer: knplabs/knp-time-bundle does not yet declare Symfony 8 support. The latest knplabs/knp-time-bundle release on Packagist (v2.4.0) lists support for Symfony ^5.4 | ^6.0 | ^7.0 (no ^8.0). [1]
Details / sources:
- Packagist (knplabs/knp-time-bundle v2.4.0 — requires symfony/* ^5.4|^6.0|^7.0). [1]
- Release note that added Symfony 7 support (v2.2.0). [2]
If you need Symfony 8 compatibility now, you can either:
- open/track an issue or PR on the repo requesting / adding Symfony 8 support, or
- fork the bundle and update its composer.json to allow ^8.0 (then run tests and fix any incompatibilities) — then require your fork until an official release adds ^8 support.
Sources:
[1] Packagist: knplabs/knp-time-bundle (v2.4.0) — requirements.
[2] Merge/Release note: v2.2.0 (added Symfony 7 support).
Production dependency knplabs/knp-time-bundle does not support Symfony 8.
knplabs/knp-time-bundle v2.4.0 (latest release) only supports symfony/dependency-injection ^5.4|^6.0|^7.0. No version 3.x exists, and Symfony 8 support is not yet declared. This blocks the PR from supporting Symfony 8. Either request the package maintainers add Symfony 8 support, or use a forked version with ^8.0 constraint until an official release is available.
| "doctrine/doctrine-fixtures-bundle": "^4.3 || 4.3.x-dev", | ||
| "liip/test-fixtures-bundle": "^3.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
doctrine/doctrine-fixtures-bundle Symfony 8 support compatibility
💡 Result:
Short answer: As of today (Dec 1, 2025) doctrine/doctrine-fixtures-bundle (latest stable 4.3.0) does not declare Symfony 8 support — its composer requirements allow symfony/* ^6.4 || ^7.0 only. See Packagist for the exact requirements. [1][2]
If you need to use fixtures on Symfony 8 now, options are:
- Test installing (composer require orm-fixtures) in a sandbox project — Composer will tell you immediately if constraints block it.
- Watch/subscribe to the DoctrineFixturesBundle GitHub/Packagist releases for a Symfony 8-compatible release. [1][3]
Sources:
- Packagist — doctrine/doctrine-fixtures-bundle (requirements shown). [1]
- Symfony docs / DoctrineFixturesBundle installation (notes to use composer require orm-fixtures). [2]
- DoctrineFixturesBundle GitHub (releases & issues). [3]
🌐 Web query:
liip/test-fixtures-bundle Symfony 8 support compatibility
💡 Result:
Short answer: Not yet — current stable liip/test-fixtures-bundle releases do not list Symfony 8 support.
Details: Packagist (latest 3.6.0) requires symfony/framework-bundle ^5.4 || ^6.3 || ^7.0 (no ^8.0 listed). This means the bundle is not marked compatible with Symfony 8 as of the package metadata (last updated Nov 22, 2025). [1]
If you need Symfony 8 support now: either watch/open an issue or PR on the bundle repo asking for Symfony 8 support, or fork the bundle and update the composer constraints and any Symfony-API usages, then run your test suite. [1]
Sources
- liip/test-fixtures-bundle (Packagist) — requirements and latest version metadata. [1]
Test dependencies do not support Symfony 8.
Both doctrine/doctrine-fixtures-bundle (latest 4.3.0) and liip/test-fixtures-bundle (latest 3.6.0) explicitly exclude Symfony 8 in their composer constraints—they require symfony/* ^6.4 || ^7.0 and symfony/framework-bundle ^5.4 || ^6.3 || ^7.0 respectively. The current constraints in lines 46–47 (^4.3 and ^3.7) will resolve to these unsupported versions, preventing composer from resolving the lock file with Symfony 8.
🤖 Prompt for AI Agents
In composer.json around lines 46–47, the dev dependencies
"doctrine/doctrine-fixtures-bundle" and "liip/test-fixtures-bundle" are
constrained to versions that do not support Symfony 8; update their require-dev
constraints to versions that explicitly support Symfony 8 (or replace them with
alternative packages that do), by running composer require --dev with the
correct version ranges that include Symfony 8, or adjust composer.json to
remove/replace these entries and then run composer update to regenerate the
lockfile and confirm composer can resolve against Symfony 8.
TODO: Run CI after Symfony 7.4 and 8 is released
Blocked by
Your requirements could not be resolved to an installable set of packages.
Summary by CodeRabbit
Chores
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.