Skip to content

Conversation

@Chris53897
Copy link
Collaborator

@Chris53897 Chris53897 commented Nov 19, 2025

TODO: Run CI after Symfony 7.4 and 8 is released

Blocked by

Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires knplabs/knp-time-bundle ^2.4 -> satisfiable by knplabs/knp-time-bundle[v2.4.0].
    - knplabs/knp-time-bundle v2.4.0 requires symfony/dependency-injection ^5.4|^6.0|^7.0 -> found symfony/dependency-injection[v5.4.0-RC1, ..., v5.4.48, v6.0.0-RC1, ..., v6.4.26, v7.0.0-RC1, ..., v7.4.0] but these were not loaded, likely because it conflicts with another require.
  Problem 2
    - Root composer.json requires doctrine/doctrine-fixtures-bundle ^4.3 -> satisfiable by doctrine/doctrine-fixtures-bundle[4.3.0].
    - doctrine/doctrine-fixtures-bundle 4.3.0 requires symfony/config ^6.4 || ^7.0 -> found symfony/config[v6.4.0-RC1, ..., v6.4.28, v7.0.0-RC1, ..., v7.4.0] but these were not loaded, likely because it conflicts with another require.
  Problem 3
    - Root composer.json requires liip/test-fixtures-bundle ^3.6 -> satisfiable by liip/test-fixtures-bundle[3.6.0].
    - liip/test-fixtures-bundle 3.6.0 requires symfony/event-dispatcher ^5.4 || ^6.3 || ^7.0 -> found symfony/event-dispatcher[v5.4.0-RC1, ..., v5.4.45, v6.3.0-RC1, ..., v6.4.25, v7.0.0-RC1, ..., v7.4.0] but these were not loaded, likely because it conflicts with another require.
  Problem 4
    - Root composer.json requires doctrine/doctrine-bundle ^2.18.0 || ^3.0 -> satisfiable by doctrine/doctrine-bundle[2.18.0, 2.18.1, 3.0.0].
    - doctrine/doctrine-bundle[2.18.0, ..., 2.18.1, 3.0.0] require symfony/cache ^6.4 || ^7.0 -> found symfony/cache[v6.4.0-RC1, ..., v6.4.28, v7.0.0-RC1, ..., v7.4.0] but these were not loaded, likely because it conflicts with another require.

Summary by CodeRabbit

  • Chores

    • Updated CI workflows and matrices: bumped checkout actions to v6, added PHP 8.5/Symfony 8 entries, and adjusted upcoming test matrix.
    • Upgraded minimum framework support to Symfony 7.4 and extended compatibility to Symfony 8; bumped several dependencies and CI/tooling settings.
    • Removed obsolete commented configuration options.
  • Documentation

    • Updated changelog to reflect new framework support and minimum requirements.

✏️ Tip: You can customize this high-level summary in your review settings.

allow symfony 8
@Chris53897 Chris53897 changed the title feat: bump min versions feat: allow symfony 8 and bump min versions Nov 19, 2025
@Chris53897 Chris53897 closed this Nov 24, 2025
@Chris53897 Chris53897 reopened this Nov 24, 2025
@Chris53897 Chris53897 closed this Nov 27, 2025
@Chris53897 Chris53897 reopened this Nov 27, 2025
allow symfony 8
@coderabbitai
Copy link

coderabbitai bot commented Nov 27, 2025

Walkthrough

Upgrade CI workflows (update checkout action, PHP/Symfony matrix entries), bump Symfony and other dependency constraints in composer.json, trim obsolete Doctrine comments in test config, and add two test comment lines; no public API changes.

Changes

Cohort / File(s) Summary
CI workflows
.github/workflows/code_checks.yaml, .github/workflows/tests-upcoming-symfony.yaml, .github/workflows/code_coverage.yaml
Update actions/checkout references from v5v6; adjust CI matrices: raise Symfony from 7.3→7.4, add Symfony 8 entries, bump PHP versions (introduce PHP 8.5) and update upcoming workflow to Symfony 8.1.x@dev.
Dependency manifest
composer.json
Bump Symfony component constraints to `^7.4
Changelog
CHANGELOG.md
Update wording to reflect added support for Symfony 7 and 8 and dropping support for Symfony < 7.4.
Test application config
Tests/App/config/config_test.yml
Remove commented/obsolete Doctrine-related config lines and a commented controller_resolver block referencing removed options.
Test comments
Tests/Constraints/CronExpressionValidatorTest.php
Insert two comment lines around an existing violation assertion; no executable/test behavior changes.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

  • Review composer.json carefully for correct OR (||) constraint placement and minimum-stability/prefer-stable semantics.
  • Verify CI matrices in .github/workflows/* for intended PHP ↔ Symfony pairings and compatibility with actions/checkout@v6.
  • Confirm removed Doctrine comments in Tests/App/config/config_test.yml are safe to drop and tests still express intended scenarios.
  • Quick check of Tests/Constraints/CronExpressionValidatorTest.php to ensure added comments don't affect test tooling.

Poem

🐇 I nudged the YAML, nudged composer too,
bumped versions up and cleared old dew.
Checkout hopped forward, matrices expand,
Doctrine's old comments left the land.
A tiny rabbit's tidy prance—cheerful, true!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat: allow symfony 8 and bump min versions' clearly and concisely summarizes the main changes: adding Symfony 8 support and bumping minimum version requirements.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/symfony-8

Comment @coderabbitai help to get the list of available commands and usage tips.

allow symfony 8
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.29%. Comparing base (f68d13f) to head (c5b742d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #160      +/-   ##
============================================
- Coverage     81.96%   81.29%   -0.67%     
  Complexity      292      292              
============================================
  Files            30       30              
  Lines          1303     1219      -84     
============================================
- Hits           1068      991      -77     
+ Misses          235      228       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Chris53897 Chris53897 closed this Nov 29, 2025
@Chris53897 Chris53897 reopened this Nov 29, 2025
allow symfony 8
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8f67510 and c5b742d.

📒 Files selected for processing (1)
  • composer.json (3 hunks)
🧰 Additional context used
🪛 GitHub Actions: Code_Checks
composer.json

[error] 1-1: Composer dependency resolution failed during 'composer update'. knplabs/knp-time-bundle v2.4.0 requires Symfony Dependency Injection ^5.4|^6.0|^7.0, but constraints present cause a conflict; Your requirements could not be resolved to an installable set of packages.

🔇 Additional comments (3)
composer.json (3)

79-79: Memory limit increase for phpstan is reasonable.

Increasing phpstan's memory limit from the default to 2048M is appropriate for analyzing larger codebases.


93-94: No action needed on minimum-stability setting.

The "dev" minimum-stability is intentional and appropriate for a bundle supporting newly-released Symfony 8.0, where some dependencies may not have stable releases yet. Combined with prefer-stable: true, this allows necessary dev versions while still preferring stable releases.


21-21: > Likely an incorrect or invalid review comment.

"doctrine/persistence": "^3.4.1 || ^4.1",
"dragonmantank/cron-expression": "^3.4",
"dragonmantank/cron-expression": "^3.6",
"knplabs/knp-time-bundle": "^2.4",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🌐 Web query:

knplabs/knp-time-bundle Symfony 8 compatibility versions

💡 Result:

Short answer: knplabs/knp-time-bundle does not yet declare Symfony 8 support. The latest knplabs/knp-time-bundle release on Packagist (v2.4.0) lists support for Symfony ^5.4 | ^6.0 | ^7.0 (no ^8.0). [1]

Details / sources:

  • Packagist (knplabs/knp-time-bundle v2.4.0 — requires symfony/* ^5.4|^6.0|^7.0). [1]
  • Release note that added Symfony 7 support (v2.2.0). [2]

If you need Symfony 8 compatibility now, you can either:

  • open/track an issue or PR on the repo requesting / adding Symfony 8 support, or
  • fork the bundle and update its composer.json to allow ^8.0 (then run tests and fix any incompatibilities) — then require your fork until an official release adds ^8 support.

Sources:
[1] Packagist: knplabs/knp-time-bundle (v2.4.0) — requirements.
[2] Merge/Release note: v2.2.0 (added Symfony 7 support).


Production dependency knplabs/knp-time-bundle does not support Symfony 8.

knplabs/knp-time-bundle v2.4.0 (latest release) only supports symfony/dependency-injection ^5.4|^6.0|^7.0. No version 3.x exists, and Symfony 8 support is not yet declared. This blocks the PR from supporting Symfony 8. Either request the package maintainers add Symfony 8 support, or use a forked version with ^8.0 constraint until an official release is available.

Comment on lines +46 to +47
"doctrine/doctrine-fixtures-bundle": "^4.3 || 4.3.x-dev",
"liip/test-fixtures-bundle": "^3.7",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🌐 Web query:

doctrine/doctrine-fixtures-bundle Symfony 8 support compatibility

💡 Result:

Short answer: As of today (Dec 1, 2025) doctrine/doctrine-fixtures-bundle (latest stable 4.3.0) does not declare Symfony 8 support — its composer requirements allow symfony/* ^6.4 || ^7.0 only. See Packagist for the exact requirements. [1][2]

If you need to use fixtures on Symfony 8 now, options are:

  • Test installing (composer require orm-fixtures) in a sandbox project — Composer will tell you immediately if constraints block it.
  • Watch/subscribe to the DoctrineFixturesBundle GitHub/Packagist releases for a Symfony 8-compatible release. [1][3]

Sources:

  • Packagist — doctrine/doctrine-fixtures-bundle (requirements shown). [1]
  • Symfony docs / DoctrineFixturesBundle installation (notes to use composer require orm-fixtures). [2]
  • DoctrineFixturesBundle GitHub (releases & issues). [3]

🌐 Web query:

liip/test-fixtures-bundle Symfony 8 support compatibility

💡 Result:

Short answer: Not yet — current stable liip/test-fixtures-bundle releases do not list Symfony 8 support.

Details: Packagist (latest 3.6.0) requires symfony/framework-bundle ^5.4 || ^6.3 || ^7.0 (no ^8.0 listed). This means the bundle is not marked compatible with Symfony 8 as of the package metadata (last updated Nov 22, 2025). [1]

If you need Symfony 8 support now: either watch/open an issue or PR on the bundle repo asking for Symfony 8 support, or fork the bundle and update the composer constraints and any Symfony-API usages, then run your test suite. [1]

Sources

  • liip/test-fixtures-bundle (Packagist) — requirements and latest version metadata. [1]

Test dependencies do not support Symfony 8.

Both doctrine/doctrine-fixtures-bundle (latest 4.3.0) and liip/test-fixtures-bundle (latest 3.6.0) explicitly exclude Symfony 8 in their composer constraints—they require symfony/* ^6.4 || ^7.0 and symfony/framework-bundle ^5.4 || ^6.3 || ^7.0 respectively. The current constraints in lines 46–47 (^4.3 and ^3.7) will resolve to these unsupported versions, preventing composer from resolving the lock file with Symfony 8.

🤖 Prompt for AI Agents
In composer.json around lines 46–47, the dev dependencies
"doctrine/doctrine-fixtures-bundle" and "liip/test-fixtures-bundle" are
constrained to versions that do not support Symfony 8; update their require-dev
constraints to versions that explicitly support Symfony 8 (or replace them with
alternative packages that do), by running composer require --dev with the
correct version ranges that include Symfony 8, or adjust composer.json to
remove/replace these entries and then run composer update to regenerate the
lockfile and confirm composer can resolve against Symfony 8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants