Repository navigation
fix(desktop): accept and order Core prerelease versions - #7
Merged
huangruiteng merged 1 commit intoOct 16, 2026
Conversation
Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
huangruiteng
merged commit Oct 16, 2026
286624b
into
Duang777:codex/remove-legacy-markdown-callers-20261012
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal And Delivered Outcome
Fix the native startup blocker found on upstream #6396: the normal macOS App rejected the valid Core wheel version
2.0.0a1asruntime_bundle_invalidbefore opening the workspace.The existing native adapter now validates and orders Core package versions using PEP 440 through
pep440_rs. It preserves the original identity string, keeps source ancestry and installation ownership decisions, and retains the historical Main-shell fallback. Stable releases rank above same-base prereleases; malformed versions still refuse. This also removes blanket prerelease/build stripping that could hide a downgrade.Intended base:
Duang777:codex/remove-legacy-markdown-callers-20261012at2ff6610a3eed91a9b3a6564af3648d937f7bc9c1. This is one signed commit touching four native/docs paths; it does not integrate additional main history.Author Declaration
Written by: model_agent — OpenAI Codex, GPT-6 family.
Implemented against the reproduced failure above and the existing archived-wheel version/ancestry contract in
apps/desktop/loopx-control-plane/README.mdat the base revision, using the Python packaging version specification.runtime_selection.rs; real normal wheel/App startupScope And Continuation
Complete author proposal for this native version adapter repair. Core/CLI state owners, leases, receipts, backup formats and storage policy are unchanged. A single private parser serves the two existing consumers; no new control-plane owner, configuration or framework is introduced.
The parent retirement PR remains open. It must incorporate the fix and satisfy its own final-head review, validation and maintainer merge gates. This proposal is not a merge or release authorization, nor a D2/default-storage qualification.
Validation
Tested revision:
bf8372b1eda6e53492b6cd256b48d6b64cf63c51. Run state: finished. Inputs: synthetic, public_fixture.cargo test --release: 112 passed, three opt-in checks ignored (private installer and signed-release fixtures);cargo fmt --checkandcargo clippy --release --all-targets -- -D warningspassed.2.0.0a1.git diff --check. The advisory does not parse Rust; the version/owner boundary was reviewed directly. Exact-scope CQRcqr_8f3f3c2cefec3a0e0d04is valid.The validation set covers the changed native adapter, its existing callers and the real failure/recovery path. Native QA leaves the installed public App unchanged; it activates no Goal and makes no model call. Broader parent-program acceptance remains with loopx-project#6396.
Frontend / Visual Evidence
UI impact: none to layout, controls or assets. The existing workspace and recovery views are used unchanged. Native behavior moves from the terminal
runtime_bundle_invalidstate to the real workspace. Synthetic QA observed the existing inactive/unknown and bad-input states; no private screenshots or raw logs are published.Type / Area
Bug fix; associated tests and native recovery documentation. Build/packaging and host/runtime integration. Shared-authority fixture impact: N/A — no state codec, provider or migration rule changes.
Boundary Checklist