feat(vmm): add static configuration validation - #906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a side-effect-free
check-configcommand for validating static configuration invariants.The extended checks run only when
check-configis explicitly requested, so existingserveandrunbehavior is unchanged. The pre-existing host API validation remains part of normal startup.Validation performed
vsock:<cid>host API address and a nonzero host API port.9p,vhd, orvvfat.The checks are intentionally limited to static invariants. They do not access external services, require host devices, or mutate host state.
Usage
A valid configuration prints
configuration is valid; an invalid one exits with an error.Tests
cargo test --manifest-path dstack/Cargo.toml -p dstack-vmm config::tests::cargo check --manifest-path dstack/Cargo.toml -p dstack-vmmcargo fmt --manifest-path dstack/Cargo.toml --allgit diff --check