[STACKED on #855] fix(guest): disable the ZFS pool root mountpoint - #860
Closed
kvinwang wants to merge 41 commits into
Closed
[STACKED on #855] fix(guest): disable the ZFS pool root mountpoint#860kvinwang wants to merge 41 commits into
kvinwang wants to merge 41 commits into
Conversation
fix(os): omit built-in FUSE module package
fix(os): fail multi-flavor builds on first error
fix(simulator): support current FUSE soname
…readiness fix(simulator): wait for GCP vTPM readiness
fix(os): install TPM device TCTI for simulator
…-log fix(simulator): expose GCP TPM event log
* test(simulator): log NitroTPM vendor commands * fix(simulator): advertise NitroTPM vendor command * style(simulator): apply repository rustfmt * fix(simulator): report live NitroTPM PCRs * chore(simulator): remove NitroTPM debug output * refactor(tpm2): support stream transports * feat(tpm2): edit command capability responses * refactor(simulator): use typed TPM APIs * fix(tpm2): preserve device response reads * test(tpm2): cover stream response framing * fix(tpm2): satisfy strict CI checks
…r-config fix(vmm): generate simulated SEV-SNP mr_config
Support multiple init scripts and measure their hashes
…surements fix(vmm): pass cloud image measurements to guests
…ed-vtpm-read fix(simulator): retry interrupted vTPM reads
kvinwang
force-pushed
the
codex/fix-guest-zfs-root-mountpoint
branch
from
August 3, 2026 13:36
792193f to
2563c2f
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The newly created ZFS pool inherited a root mountpoint, so importing it could mount the pool root in addition to the explicitly managed datasets. That created an unmanaged mount and could collide with the guest volume layout.
Root cause and fix
Create/configure the pool with its root mountpoint disabled; only the intended child datasets receive mountpoints.
Implementation
The branch records the following focused implementation work:
fix(guest): disable the ZFS pool root mountpointChanged paths:
dstack/dstack-util/src/system_setup.rsScope
This PR addresses one logical
guestfinding. It intentionally excludes the acceptance-test infrastructure from #841 and unrelated product fixes from #840.Dependency and merge order
codex/fix-guest-zfs-pool-errorsVerification
git diff --check origin/codex/fix-guest-zfs-pool-errors..origin/codex/fix-guest-zfs-root-mountpoint: passed.