fix(vmm): reap VM launcher children on SvStop - #858
Merged
Conversation
Overwriting Exited(code)/Error states with Stopped on SvStop masked crash diagnostics in sv_list and clobbered the exit timestamp the wait task had recorded. Narrow the normalization to Exited(0) so an explicit stop still reads as stopped while non-zero exit codes and error states stay visible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SvStopstopped VM services without reaping their launcher child processes. Repeated stop/start operations could leave zombies and stale launcher state even though VMM reported the VM stopped.Root cause and fix
Wait for and reap launcher children as part of
SvStop, preserving the launcher exit result instead of orphaning the process.Implementation
The branch records the following focused implementation work:
fix(vmm): reap VM launcher children on SvStopfix(vmm): keep SvStop unknown IDs rejectedChanged paths:
dstack/supervisor/src/process.rsdstack/vmm/src/app.rsdstack/vmm/src/main_service.rsScope
This PR addresses one logical
vmmfinding. It intentionally excludes the acceptance-test infrastructure from #841 and unrelated product fixes from #840.Dependency and merge order
This PR is based directly on
masterand does not require another split product PR to merge first.Verification
git diff --check origin/master..origin/codex/fix-vmm-svstop-child-reaping: passed.