Skip to content

fix(simulator): identify simulated Nitro Enclave guests - #854

Merged
kvinwang merged 2 commits into
masterfrom
codex/fix-nitro-enclave-platform-detection
Aug 3, 2026
Merged

fix(simulator): identify simulated Nitro Enclave guests#854
kvinwang merged 2 commits into
masterfrom
codex/fix-nitro-enclave-platform-detection

Conversation

@kvinwang

@kvinwang kvinwang commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Problem

Simulated Nitro Enclave guests were not identified as Nitro in guest-side platform detection. Code selecting attestation and measurement behavior therefore took the generic/non-Nitro path even though the guest used the Nitro simulator.

Root cause and fix

Recognize the DMI identity installed by the guest-side simulator and skip the TDX-only MR_CONFIG_ID check for Nitro Enclave guests.

The simulator remains the single owner of simulated DMI identity. The VMM does not override QEMU SMBIOS.

Implementation

  • fix(simulator): detect Nitro Enclave DMI
  • fix(guest): skip TDX config check on Nitro Enclave

Changed paths:

  • dstack/dstack-types/src/lib.rs
  • dstack/dstack-util/src/system_setup/config_id_verifier.rs

Scope

This PR addresses one logical simulator finding. It intentionally excludes the acceptance-test infrastructure from #841 and unrelated product fixes from #840.

Dependency and merge order

This PR is based directly on master and does not require another split product PR to merge first.

Verification

  • cargo test -p dstack-types detects_nitro_enclave_from_simulated_dmi: passed
  • cargo test -p dstack-util nitro_enclave_does_not_require_tdx_mr_config: passed
  • git diff --check origin/master...HEAD: passed

Copilot AI review requested due to automatic review settings July 31, 2026 02:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@kvinwang
kvinwang force-pushed the codex/fix-nitro-enclave-platform-detection branch from 3f44b55 to 4c9b4ae Compare August 3, 2026 13:11
@kvinwang
kvinwang force-pushed the codex/fix-nitro-enclave-platform-detection branch from 4c9b4ae to 4943289 Compare August 3, 2026 13:47
@kvinwang
kvinwang merged commit e288de9 into master Aug 3, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants