fix(simulator): identify simulated Nitro Enclave guests - #854
Merged
Conversation
kvinwang
force-pushed
the
codex/fix-nitro-enclave-platform-detection
branch
from
August 3, 2026 13:11
3f44b55 to
4c9b4ae
Compare
kvinwang
force-pushed
the
codex/fix-nitro-enclave-platform-detection
branch
from
August 3, 2026 13:47
4c9b4ae to
4943289
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Simulated Nitro Enclave guests were not identified as Nitro in guest-side platform detection. Code selecting attestation and measurement behavior therefore took the generic/non-Nitro path even though the guest used the Nitro simulator.
Root cause and fix
Recognize the DMI identity installed by the guest-side simulator and skip the TDX-only MR_CONFIG_ID check for Nitro Enclave guests.
The simulator remains the single owner of simulated DMI identity. The VMM does not override QEMU SMBIOS.
Implementation
fix(simulator): detect Nitro Enclave DMIfix(guest): skip TDX config check on Nitro EnclaveChanged paths:
dstack/dstack-types/src/lib.rsdstack/dstack-util/src/system_setup/config_id_verifier.rsScope
This PR addresses one logical simulator finding. It intentionally excludes the acceptance-test infrastructure from #841 and unrelated product fixes from #840.
Dependency and merge order
This PR is based directly on
masterand does not require another split product PR to merge first.Verification
cargo test -p dstack-types detects_nitro_enclave_from_simulated_dmi: passedcargo test -p dstack-util nitro_enclave_does_not_require_tdx_mr_config: passedgit diff --check origin/master...HEAD: passed